Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: runtime/vm/parser_test.cc

Issue 1870343002: - Refactor Symbol allocation to expect a thread parameter. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address review feedback. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/parser.cc ('k') | runtime/vm/precompiler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser_test.cc
diff --git a/runtime/vm/parser_test.cc b/runtime/vm/parser_test.cc
index fe9230871903c676ec1c529057394661e572575e..120e5cace0c231717441ed07ec749e35699eb20c 100644
--- a/runtime/vm/parser_test.cc
+++ b/runtime/vm/parser_test.cc
@@ -21,7 +21,8 @@ DECLARE_FLAG(bool, show_invisible_frames);
static void DumpFunction(const Library& lib,
const char* cname,
const char* fname) {
- const String& classname = String::Handle(Symbols::New(cname));
+ const String& classname = String::Handle(Symbols::New(Thread::Current(),
+ cname));
String& funcname = String::Handle(String::New(fname));
bool retval;
@@ -56,7 +57,8 @@ void CheckField(const Library& lib,
const char* field_name,
bool expect_static,
bool is_final) {
- const String& classname = String::Handle(Symbols::New(class_name));
+ const String& classname = String::Handle(Symbols::New(Thread::Current(),
+ class_name));
Class& cls = Class::Handle(lib.LookupClass(classname));
EXPECT(!cls.IsNull());
@@ -91,7 +93,8 @@ void CheckFunction(const Library& lib,
const char* class_name,
const char* function_name,
bool expect_static) {
- const String& classname = String::Handle(Symbols::New(class_name));
+ const String& classname = String::Handle(Symbols::New(Thread::Current(),
+ class_name));
Class& cls = Class::Handle(lib.LookupClass(classname));
EXPECT(!cls.IsNull());
« no previous file with comments | « runtime/vm/parser.cc ('k') | runtime/vm/precompiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698