Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 186593007: Remove href_change and navigate from wait action (Closed)

Created:
6 years, 9 months ago by nednguyen
Modified:
6 years, 9 months ago
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove href_change and navigate from wait. Add wait_until to support href_change and navigate. Remove previous_action for page_actions.RunAction. Change page_sets that use wait's href_change and navigate to using wait_until instead. BUG=349584 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255560

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -199 lines) Patch
M tools/perf/page_sets/gmail_alt_threadlist_conversation.json View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/perf/page_sets/gmail_alt_two_labels.json View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/perf/page_sets/top_25.json View 5 chunks +44 lines, -44 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/gesture_action.py View 1 chunk +8 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/gesture_action_unittest.py View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/interact.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/javascript.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/javascript_click.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/javascript_click_unittest.py View 5 chunks +9 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/js_collect_garbage.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/loop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/loop_unittest.py View 3 chunks +4 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/media_action.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/navigate.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/navigate_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/page_action.py View 4 chunks +19 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/pinch.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/play.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/play_unittest.py View 7 chunks +7 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/reload.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/scroll.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/scroll_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/seek.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/seek_unittest.py View 4 chunks +5 lines, -7 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/set_startup_url.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/swipe.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/tap.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/wait.py View 1 chunk +5 lines, -22 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/wait_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
A tools/telemetry/telemetry/page/actions/wait_until.py View 1 chunk +56 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/page_measurement_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/page_test.py View 1 chunk +8 lines, -16 lines 0 comments Download
M tools/telemetry/telemetry/page/page_test_unittest.py View 4 chunks +7 lines, -40 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
nednguyen
6 years, 9 months ago (2014-03-06 19:35:16 UTC) #1
nduca
this is really elegant lgtm
6 years, 9 months ago (2014-03-06 22:37:56 UTC) #2
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 9 months ago (2014-03-06 23:44:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/186593007/1
6 years, 9 months ago (2014-03-06 23:59:12 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 02:31:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 9 months ago (2014-03-07 02:31:03 UTC) #6
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 9 months ago (2014-03-07 04:09:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/186593007/1
6 years, 9 months ago (2014-03-07 04:14:14 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 09:06:59 UTC) #9
Message was sent while issue was closed. 
Change committed as 255560

Powered by Google App Engine
This is Rietveld 408576698