Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: tools/telemetry/telemetry/page/actions/loop_unittest.py

Issue 186593007: Remove href_change and navigate from wait action (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/actions/loop_unittest.py
diff --git a/tools/telemetry/telemetry/page/actions/loop_unittest.py b/tools/telemetry/telemetry/page/actions/loop_unittest.py
index 4eee9337e5f7e9e18df2d12571970f28d4c9e691..6d256a15f90075fa0aa3969febfed767e243dd41 100644
--- a/tools/telemetry/telemetry/page/actions/loop_unittest.py
+++ b/tools/telemetry/telemetry/page/actions/loop_unittest.py
@@ -21,7 +21,7 @@ class LoopActionTest(tab_test_case.TabTestCase):
data = {'selector': '#video_1', 'loop_count': 2}
action = loop.LoopAction(data)
action.WillRunAction(None, self._tab)
- action.RunAction(None, self._tab, None)
+ action.RunAction(None, self._tab)
# Assert only first video has played.
self.assertTrue(self._tab.EvaluateJavaScript(VIDEO_1_LOOP_CHECK))
self.assertFalse(self._tab.EvaluateJavaScript(AUDIO_1_LOOP_CHECK))
@@ -34,7 +34,7 @@ class LoopActionTest(tab_test_case.TabTestCase):
# Both videos not playing before running action.
self.assertFalse(self._tab.EvaluateJavaScript(VIDEO_1_LOOP_CHECK))
self.assertFalse(self._tab.EvaluateJavaScript(AUDIO_1_LOOP_CHECK))
- action.RunAction(None, self._tab, None)
+ action.RunAction(None, self._tab)
# Assert all media elements played.
self.assertTrue(self._tab.EvaluateJavaScript(VIDEO_1_LOOP_CHECK))
self.assertTrue(self._tab.EvaluateJavaScript(AUDIO_1_LOOP_CHECK))
@@ -47,12 +47,11 @@ class LoopActionTest(tab_test_case.TabTestCase):
action = loop.LoopAction(data)
action.WillRunAction(None, self._tab)
self.assertFalse(self._tab.EvaluateJavaScript(VIDEO_1_LOOP_CHECK))
- self.assertRaises(util.TimeoutException, action.RunAction, None, self._tab,
- None)
+ self.assertRaises(util.TimeoutException, action.RunAction, None, self._tab)
def testLoopWithoutLoopCount(self):
"""Tests that loop action fails with no loop count."""
data = {}
action = loop.LoopAction(data)
action.WillRunAction(None, self._tab)
- self.assertRaises(AssertionError, action.RunAction, None, self._tab, None)
+ self.assertRaises(AssertionError, action.RunAction, None, self._tab)
« no previous file with comments | « tools/telemetry/telemetry/page/actions/loop.py ('k') | tools/telemetry/telemetry/page/actions/media_action.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698