tools/telemetry/telemetry/page/actions/pinch.py - Issue 186593007: Remove href_change and navigate from wait action

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/actions/pinch.py

Issue 186593007: Remove href_change and navigate from wait action (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/page/actions/pinch.py

diff --git a/tools/telemetry/telemetry/page/actions/pinch.py b/tools/telemetry/telemetry/page/actions/pinch.py

index cf9d4e1f3c6f295a1f4443dc7344fbb9d5063cc5..f600427e9d9eb037a9c5716560bf07442c88cd08 100644

--- a/tools/telemetry/telemetry/page/actions/pinch.py

+++ b/tools/telemetry/telemetry/page/actions/pinch.py

@@ -33,7 +33,7 @@ class PinchAction(GestureAction):

window.__pinchAction = new __PinchAction(%s);"""

% done_callback)

- def RunGesture(self, page, tab, previous_action):

+ def RunGesture(self, page, tab):

left_anchor_percentage = getattr(self, 'left_anchor_percentage', 0.5)

top_anchor_percentage = getattr(self, 'top_anchor_percentage', 0.5)

zoom_in = getattr(self, 'zoom_in', True)