tools/telemetry/telemetry/page/actions/play.py - Issue 186593007: Remove href_change and navigate from wait action

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/actions/play.py

Issue 186593007: Remove href_change and navigate from wait action (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/page/actions/play.py

diff --git a/tools/telemetry/telemetry/page/actions/play.py b/tools/telemetry/telemetry/page/actions/play.py

index 9fdf90563eb373f38078dbac6b50c046bb191aad..bb32b583020c267321cee63a3d8410bc9623656c 100644

--- a/tools/telemetry/telemetry/page/actions/play.py

+++ b/tools/telemetry/telemetry/page/actions/play.py

@@ -26,7 +26,7 @@ class PlayAction(media_action.MediaAction):

super(PlayAction, self).WillRunAction(page, tab)

self.LoadJS(tab, 'play.js')

- def RunAction(self, page, tab, previous_action):

+ def RunAction(self, page, tab):

try:

selector = self.selector if hasattr(self, 'selector') else ''

tab.ExecuteJavaScript('window.__playMedia("%s");' % selector)