tools/telemetry/telemetry/page/actions/javascript.py - Issue 186593007: Remove href_change and navigate from wait action

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/actions/javascript.py

Issue 186593007: Remove href_change and navigate from wait action (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/page/actions/javascript.py

diff --git a/tools/telemetry/telemetry/page/actions/javascript.py b/tools/telemetry/telemetry/page/actions/javascript.py

index 2edccefe1be070f572731be331328b803307f95c..8f82b337525212e74a662975cc641a7491f0a64c 100644

--- a/tools/telemetry/telemetry/page/actions/javascript.py

+++ b/tools/telemetry/telemetry/page/actions/javascript.py

@@ -9,6 +9,6 @@ class JavascriptAction(page_action.PageAction):

def __init__(self, attributes=None):

super(JavascriptAction, self).__init__(attributes)

- def RunAction(self, page, tab, previous_action):

+ def RunAction(self, page, tab):

assert hasattr(self, 'expression')

- tab.ExecuteJavaScript(self.expression)

+ tab.ExecuteJavaScript(self.expression)