tools/telemetry/telemetry/page/actions/scroll.py - Issue 186593007: Remove href_change and navigate from wait action

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/actions/scroll.py

Issue 186593007: Remove href_change and navigate from wait action (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/page/actions/scroll.py

diff --git a/tools/telemetry/telemetry/page/actions/scroll.py b/tools/telemetry/telemetry/page/actions/scroll.py

index a3dcf30bf6d608633d60cc67bac43564399dae4d..5b990e4b6daeb9fa081398b2a32b487c1778a216 100644

--- a/tools/telemetry/telemetry/page/actions/scroll.py

+++ b/tools/telemetry/telemetry/page/actions/scroll.py

@@ -47,7 +47,7 @@ class ScrollAction(GestureAction):

window.__scrollAction = new __ScrollAction(%s, %s);"""

% (done_callback, distance_func))

- def RunGesture(self, page, tab, previous_action):

+ def RunGesture(self, page, tab):

# scrollable_element_function is a function that passes the scrollable

# element on the page to a callback. For example:

# function (callback) {