tools/telemetry/telemetry/page/actions/wait_unittest.py - Issue 186593007: Remove href_change and navigate from wait action

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/actions/wait_unittest.py

Issue 186593007: Remove href_change and navigate from wait action (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/page/actions/wait_unittest.py

diff --git a/tools/telemetry/telemetry/page/actions/wait_unittest.py b/tools/telemetry/telemetry/page/actions/wait_unittest.py

index a3994b72937878639b3a8addb2236d06ce537034..5355f380f086dcc0332118c5f96fb14311a9c074 100644

--- a/tools/telemetry/telemetry/page/actions/wait_unittest.py

+++ b/tools/telemetry/telemetry/page/actions/wait_unittest.py

@@ -19,7 +19,7 @@ class WaitActionTest(tab_test_case.TabTestCase):

i = wait.WaitAction({ 'condition': 'duration', 'seconds': 1 })

start_time = time.time()

- i.RunAction(None, self._tab, None)

+ i.RunAction(None, self._tab)

self.assertTrue(time.time() - start_time >= 1.0)

def testWaitActionTimeout(self):

@@ -32,5 +32,5 @@ class WaitActionTest(tab_test_case.TabTestCase):

start_time = time.time()

self.assertRaises(

util.TimeoutException,

- lambda: wait_action.RunAction(None, self._tab, None))

+ lambda: wait_action.RunAction(None, self._tab))

self.assertTrue(time.time() - start_time < 5)