Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: tools/telemetry/telemetry/page/actions/seek_unittest.py

Issue 186593007: Remove href_change and navigate from wait action (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/actions/seek_unittest.py
diff --git a/tools/telemetry/telemetry/page/actions/seek_unittest.py b/tools/telemetry/telemetry/page/actions/seek_unittest.py
index fd021f03824b05e0d7c85cd8397fbc9108d71200..61765072206df13904a565c9dc91da0486f1333e 100644
--- a/tools/telemetry/telemetry/page/actions/seek_unittest.py
+++ b/tools/telemetry/telemetry/page/actions/seek_unittest.py
@@ -22,7 +22,7 @@ class SeekActionTest(tab_test_case.TabTestCase):
data = {'wait_for_seeked': True, 'seek_time': 1}
action = seek.SeekAction(data)
action.WillRunAction(None, self._tab)
- action.RunAction(None, self._tab, None)
+ action.RunAction(None, self._tab)
# Assert only first video has played.
self.assertTrue(self._tab.EvaluateJavaScript(VIDEO_1_SEEKED_CHECK))
self.assertFalse(self._tab.EvaluateJavaScript(AUDIO_1_SEEKED_CHECK))
@@ -35,7 +35,7 @@ class SeekActionTest(tab_test_case.TabTestCase):
# Both videos not playing before running action.
self.assertFalse(self._tab.EvaluateJavaScript(VIDEO_1_SEEKED_CHECK))
self.assertFalse(self._tab.EvaluateJavaScript(AUDIO_1_SEEKED_CHECK))
- action.RunAction(None, self._tab, None)
+ action.RunAction(None, self._tab)
# Assert only video matching selector has played.
self.assertTrue(self._tab.EvaluateJavaScript(VIDEO_1_SEEKED_CHECK))
self.assertFalse(self._tab.EvaluateJavaScript(AUDIO_1_SEEKED_CHECK))
@@ -48,7 +48,7 @@ class SeekActionTest(tab_test_case.TabTestCase):
# Both videos not playing before running action.
self.assertFalse(self._tab.EvaluateJavaScript(VIDEO_1_SEEKED_CHECK))
self.assertFalse(self._tab.EvaluateJavaScript(AUDIO_1_SEEKED_CHECK))
- action.RunAction(None, self._tab, None)
+ action.RunAction(None, self._tab)
# Assert all media elements played.
self.assertTrue(self._tab.EvaluateJavaScript(VIDEO_1_SEEKED_CHECK))
self.assertTrue(self._tab.EvaluateJavaScript(AUDIO_1_SEEKED_CHECK))
@@ -63,13 +63,11 @@ class SeekActionTest(tab_test_case.TabTestCase):
action.WillRunAction(None, self._tab)
self._tab.EvaluateJavaScript('document.getElementById("video_1").src = ""')
self.assertFalse(self._tab.EvaluateJavaScript(VIDEO_1_SEEKED_CHECK))
- self.assertRaises(util.TimeoutException, action.RunAction, None, self._tab,
- None)
+ self.assertRaises(util.TimeoutException, action.RunAction, None, self._tab)
def testSeekWithoutSeekTime(self):
"""Tests that seek action fails with no seek time."""
data = {'wait_for_seeked': True}
action = seek.SeekAction(data)
action.WillRunAction(None, self._tab)
- self.assertRaises(AssertionError, action.RunAction, None, self._tab,
- None)
+ self.assertRaises(AssertionError, action.RunAction, None, self._tab)
« no previous file with comments | « tools/telemetry/telemetry/page/actions/seek.py ('k') | tools/telemetry/telemetry/page/actions/set_startup_url.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698