tools/perf/page_sets/gmail_alt_threadlist_conversation.json - Issue 186593007: Remove href_change and navigate from wait action

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/gmail_alt_threadlist_conversation.json

Issue 186593007: Remove href_change and navigate from wait action (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/page_sets/gmail_alt_threadlist_conversation.json

diff --git a/tools/perf/page_sets/gmail_alt_threadlist_conversation.json b/tools/perf/page_sets/gmail_alt_threadlist_conversation.json

index 97150fe289720c7787b931bd2413806f3830bf60..c096807a07f653ad58f13c91ea806d317f32d684 100644

--- a/tools/perf/page_sets/gmail_alt_threadlist_conversation.json

+++ b/tools/perf/page_sets/gmail_alt_threadlist_conversation.json

@@ -16,15 +16,15 @@

"endure": [

{

"action": "javascript_click",

- "xpath": "//span[@email]"

+ "xpath": "//span[@email]",

+ "wait_until" : { "condition" : "href_change" }

- { "action": "wait", "condition": "href_change" },

{ "action": "wait", "seconds": 1 },

{

"action": "javascript_click",

- "selector": "a[href=\"https://mail.google.com/mail/u/0/?shva=1#inbox\"]"

+ "selector": "a[href=\"https://mail.google.com/mail/u/0/?shva=1#inbox\"]",

+ "wait_until" : { "condition" : "href_change" }

- { "action": "wait", "condition": "href_change" },

{ "action": "wait", "seconds": 1 }

]

}

« no previous file with comments | « no previous file | tools/perf/page_sets/gmail_alt_two_labels.json » ('j') | no next file with comments »