tools/telemetry/telemetry/page/actions/reload.py - Issue 186593007: Remove href_change and navigate from wait action

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/actions/reload.py

Issue 186593007: Remove href_change and navigate from wait action (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/page/actions/reload.py

diff --git a/tools/telemetry/telemetry/page/actions/reload.py b/tools/telemetry/telemetry/page/actions/reload.py

index c98853c452cf92cb033f141b924a463329e09fab..4d9799977085b3c00fcad8945e8166b4c2ec59f9 100644

--- a/tools/telemetry/telemetry/page/actions/reload.py

+++ b/tools/telemetry/telemetry/page/actions/reload.py

@@ -8,6 +8,6 @@ class ReloadAction(page_action.PageAction):

def __init__(self, attributes=None):

super(ReloadAction, self).__init__(attributes)

- def RunAction(self, page, tab, previous_action):

+ def RunAction(self, page, tab):

tab.ExecuteJavaScript('window.location.reload()')

tab.WaitForDocumentReadyStateToBeInteractiveOrBetter()