[Extensions UI] Use the ExtensionMessageBubbleBridge for Views platforms

[Extensions UI] Use the ExtensionMessageBubbleBridge for Views platforms

The ExtensionMessageBubbleBridge is a layer on top of an
ExtensionMessageBubbleController that allows us to use it with a
ToolbarActionsBarBubble. Use this same interface, which immediately
allows us to remove ExtensionMessageBubbleController-specific methods
in ToolbarActionsBar and it's platform-specific counterparts and makes
both bubble showing flows follow the same path (easier to reason, less
likely to conflict).

As a next step, we can replace the ExtensionMessageBubbleView with the
ToolbarActionsBarBubbleView, similar to what we have on mac, so that
there's one less bubble to deal with.

BUG=601975
TBR=sky@chromium.org (c/b/ui/views/settings_api_bubble_helper_views.cc,
reviewed by Finnur)

Committed: https://crrev.com/8befae922ea2ab1cc82b881dbb6bd91db852f51c
Cr-Commit-Position: refs/heads/master@{#386565}

[Devlin, 2016-04-09 01:22:55]

Patchset #1 (id:1) has been deleted

[Devlin, 2016-04-09 01:23:03]

Patchset #1 (id:20001) has been deleted

[Devlin, 2016-04-09 01:23:09]

Patchset #1 (id:40001) has been deleted

[Devlin, 2016-04-09 01:23:15]

Patchset #1 (id:60001) has been deleted

[Devlin, 2016-04-09 01:27:23]

Description was changed from

==========
Bubbles
BUG=
==========

to

==========
[Extensions UI] Use the ExtensionMessageBubbleBridge for Views platforms

The ExtensionMessageBubbleBridge is a layer on top of an
ExtensionMessageBubbleController that allows us to use it with a
ToolbarActionsBarBubble. Use this same interface, which immediately
allows us to remove ExtensionMessageBubbleController-specific methods
in ToolbarActionsBar and it's platform-specific counterparts and makes
both bubble showing flows follow the same path (easier to reason, less
likely to conflict).

As a next step, we can replace the ExtensionMessageBubbleView with the
ToolbarActionsBarBubbleView, similar to what we have on mac, so that
there's one less bubble to deal with.

BUG=601975
==========

[Devlin, 2016-04-09 01:29:20]

Finnur, mind taking a look?  (I'll have Avi take the Cocoa once you've had a
chance to look it over).

https://codereview.chromium.org/1858773006/diff/80001/chrome/browser/ui/views...
File chrome/browser/ui/views/toolbar/browser_actions_container.cc (right):

https://codereview.chromium.org/1858773006/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/toolbar/browser_actions_container.cc:331: if
(controller->IsExtensionMessageBubble()) {
This is quite temporary - I have a followup patch to make
ToolbarActionsBarBubbleViews do the work that ExtensionMessageBubbleView does
now.

[Devlin, 2016-04-09 01:29:38]

rdevlin.cronin@chromium.org changed reviewers:
+ finnur@chromium.org

[Devlin, 2016-04-09 01:29:38]

+Finnur for real this time. :)

[Finnur, 2016-04-11 10:01:50]

LGTM

[Devlin, 2016-04-11 17:37:31]

rdevlin.cronin@chromium.org changed reviewers:
+ avi@chromium.org

[Devlin, 2016-04-11 17:37:32]

+Avi for Cocoa.

[Avi (use Gerrit), 2016-04-11 18:17:20]

Cocoa lgtm

[Devlin, 2016-04-12 00:55:58]

Description was changed from

==========
[Extensions UI] Use the ExtensionMessageBubbleBridge for Views platforms

The ExtensionMessageBubbleBridge is a layer on top of an
ExtensionMessageBubbleController that allows us to use it with a
ToolbarActionsBarBubble. Use this same interface, which immediately
allows us to remove ExtensionMessageBubbleController-specific methods
in ToolbarActionsBar and it's platform-specific counterparts and makes
both bubble showing flows follow the same path (easier to reason, less
likely to conflict).

As a next step, we can replace the ExtensionMessageBubbleView with the
ToolbarActionsBarBubbleView, similar to what we have on mac, so that
there's one less bubble to deal with.

BUG=601975
==========

to

==========
[Extensions UI] Use the ExtensionMessageBubbleBridge for Views platforms

The ExtensionMessageBubbleBridge is a layer on top of an
ExtensionMessageBubbleController that allows us to use it with a
ToolbarActionsBarBubble. Use this same interface, which immediately
allows us to remove ExtensionMessageBubbleController-specific methods
in ToolbarActionsBar and it's platform-specific counterparts and makes
both bubble showing flows follow the same path (easier to reason, less
likely to conflict).

As a next step, we can replace the ExtensionMessageBubbleView with the
ToolbarActionsBarBubbleView, similar to what we have on mac, so that
there's one less bubble to deal with.

BUG=601975
TBR=sky@chromium.org (c/b/ui/views/settings_api_bubble_helper_views.cc, reviewed
by Finnur)
==========

[Devlin, 2016-04-12 00:56:17]

Description was changed from

==========
[Extensions UI] Use the ExtensionMessageBubbleBridge for Views platforms

The ExtensionMessageBubbleBridge is a layer on top of an
ExtensionMessageBubbleController that allows us to use it with a
ToolbarActionsBarBubble. Use this same interface, which immediately
allows us to remove ExtensionMessageBubbleController-specific methods
in ToolbarActionsBar and it's platform-specific counterparts and makes
both bubble showing flows follow the same path (easier to reason, less
likely to conflict).

As a next step, we can replace the ExtensionMessageBubbleView with the
ToolbarActionsBarBubbleView, similar to what we have on mac, so that
there's one less bubble to deal with.

BUG=601975
TBR=sky@chromium.org (c/b/ui/views/settings_api_bubble_helper_views.cc, reviewed
by Finnur)
==========

to

==========
[Extensions UI] Use the ExtensionMessageBubbleBridge for Views platforms

The ExtensionMessageBubbleBridge is a layer on top of an
ExtensionMessageBubbleController that allows us to use it with a
ToolbarActionsBarBubble. Use this same interface, which immediately
allows us to remove ExtensionMessageBubbleController-specific methods
in ToolbarActionsBar and it's platform-specific counterparts and makes
both bubble showing flows follow the same path (easier to reason, less
likely to conflict).

As a next step, we can replace the ExtensionMessageBubbleView with the
ToolbarActionsBarBubbleView, similar to what we have on mac, so that
there's one less bubble to deal with.

BUG=601975
TBR=sky@chromium.org (c/b/ui/views/settings_api_bubble_helper_views.cc,
reviewed by Finnur)
==========

[Devlin, 2016-04-12 00:56:28]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-04-12 00:57:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1858773006/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1858773006/100001

[commit-bot: I haz the power, 2016-04-12 03:19:40]

Description was changed from

==========
[Extensions UI] Use the ExtensionMessageBubbleBridge for Views platforms

The ExtensionMessageBubbleBridge is a layer on top of an
ExtensionMessageBubbleController that allows us to use it with a
ToolbarActionsBarBubble. Use this same interface, which immediately
allows us to remove ExtensionMessageBubbleController-specific methods
in ToolbarActionsBar and it's platform-specific counterparts and makes
both bubble showing flows follow the same path (easier to reason, less
likely to conflict).

As a next step, we can replace the ExtensionMessageBubbleView with the
ToolbarActionsBarBubbleView, similar to what we have on mac, so that
there's one less bubble to deal with.

BUG=601975
TBR=sky@chromium.org (c/b/ui/views/settings_api_bubble_helper_views.cc,
reviewed by Finnur)
==========

to

==========
[Extensions UI] Use the ExtensionMessageBubbleBridge for Views platforms

The ExtensionMessageBubbleBridge is a layer on top of an
ExtensionMessageBubbleController that allows us to use it with a
ToolbarActionsBarBubble. Use this same interface, which immediately
allows us to remove ExtensionMessageBubbleController-specific methods
in ToolbarActionsBar and it's platform-specific counterparts and makes
both bubble showing flows follow the same path (easier to reason, less
likely to conflict).

As a next step, we can replace the ExtensionMessageBubbleView with the
ToolbarActionsBarBubbleView, similar to what we have on mac, so that
there's one less bubble to deal with.

BUG=601975
TBR=sky@chromium.org (c/b/ui/views/settings_api_bubble_helper_views.cc,
reviewed by Finnur)
==========

[commit-bot: I haz the power, 2016-04-12 03:19:41]

Committed patchset #2 (id:100001)

[commit-bot: I haz the power, 2016-04-12 03:21:09]

Description was changed from

==========
[Extensions UI] Use the ExtensionMessageBubbleBridge for Views platforms

The ExtensionMessageBubbleBridge is a layer on top of an
ExtensionMessageBubbleController that allows us to use it with a
ToolbarActionsBarBubble. Use this same interface, which immediately
allows us to remove ExtensionMessageBubbleController-specific methods
in ToolbarActionsBar and it's platform-specific counterparts and makes
both bubble showing flows follow the same path (easier to reason, less
likely to conflict).

As a next step, we can replace the ExtensionMessageBubbleView with the
ToolbarActionsBarBubbleView, similar to what we have on mac, so that
there's one less bubble to deal with.

BUG=601975
TBR=sky@chromium.org (c/b/ui/views/settings_api_bubble_helper_views.cc,
reviewed by Finnur)
==========

to

==========
[Extensions UI] Use the ExtensionMessageBubbleBridge for Views platforms

The ExtensionMessageBubbleBridge is a layer on top of an
ExtensionMessageBubbleController that allows us to use it with a
ToolbarActionsBarBubble. Use this same interface, which immediately
allows us to remove ExtensionMessageBubbleController-specific methods
in ToolbarActionsBar and it's platform-specific counterparts and makes
both bubble showing flows follow the same path (easier to reason, less
likely to conflict).

As a next step, we can replace the ExtensionMessageBubbleView with the
ToolbarActionsBarBubbleView, similar to what we have on mac, so that
there's one less bubble to deal with.

BUG=601975
TBR=sky@chromium.org (c/b/ui/views/settings_api_bubble_helper_views.cc,
reviewed by Finnur)

Committed: https://crrev.com/8befae922ea2ab1cc82b881dbb6bd91db852f51c
Cr-Commit-Position: refs/heads/master@{#386565}
==========

[commit-bot: I haz the power, 2016-04-12 03:21:10]

Patchset 2 (id:??) landed as
https://crrev.com/8befae922ea2ab1cc82b881dbb6bd91db852f51c
Cr-Commit-Position: refs/heads/master@{#386565}