Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9025)

Unified Diff: chrome/browser/ui/toolbar/test_toolbar_actions_bar_bubble_delegate.cc

Issue 1858773006: [Extensions UI] Use the ExtensionMessageBubbleBridge for Views platforms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/toolbar/test_toolbar_actions_bar_bubble_delegate.cc
diff --git a/chrome/browser/ui/toolbar/test_toolbar_actions_bar_bubble_delegate.cc b/chrome/browser/ui/toolbar/test_toolbar_actions_bar_bubble_delegate.cc
index 2ae1cebf8452b95abb656a93dd7c6e1d5c64eea3..2ea18764d5e8e05e5a0969053622d067280043fa 100644
--- a/chrome/browser/ui/toolbar/test_toolbar_actions_bar_bubble_delegate.cc
+++ b/chrome/browser/ui/toolbar/test_toolbar_actions_bar_bubble_delegate.cc
@@ -15,8 +15,14 @@ class TestToolbarActionsBarBubbleDelegate::DelegateImpl
~DelegateImpl() override {}
private:
+ bool ShouldShow() override { return true; }
+ bool ShouldCloseOnDeactivate() override {
+ return parent_->close_on_deactivate_;
+ }
base::string16 GetHeadingText() override { return parent_->heading_; }
- base::string16 GetBodyText() override { return parent_->body_; }
+ base::string16 GetBodyText(bool anchored_to_action) override {
+ return parent_->body_;
+ }
base::string16 GetItemListText() override { return parent_->item_list_; }
base::string16 GetActionButtonText() override { return parent_->action_; }
base::string16 GetDismissButtonText() override { return parent_->dismiss_; }
@@ -32,6 +38,7 @@ class TestToolbarActionsBarBubbleDelegate::DelegateImpl
CHECK(!parent_->close_action_);
parent_->close_action_.reset(new CloseAction(action));
}
+ bool IsExtensionMessageBubble() override { return false; }
TestToolbarActionsBarBubbleDelegate* parent_;
@@ -45,7 +52,8 @@ TestToolbarActionsBarBubbleDelegate::TestToolbarActionsBarBubbleDelegate(
: shown_(false),
heading_(heading),
body_(body),
- action_(action) {
+ action_(action),
+ close_on_deactivate_(true) {
}
TestToolbarActionsBarBubbleDelegate::~TestToolbarActionsBarBubbleDelegate() {
« no previous file with comments | « chrome/browser/ui/toolbar/test_toolbar_actions_bar_bubble_delegate.h ('k') | chrome/browser/ui/toolbar/toolbar_actions_bar.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698