chrome/browser/ui/toolbar/toolbar_actions_bar_delegate.h - Issue 1858773006: [Extensions UI] Use the ExtensionMessageBubbleBridge for Views platforms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/toolbar_actions_bar_delegate.h

Issue 1858773006: [Extensions UI] Use the ExtensionMessageBubbleBridge for Views platforms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/toolbar/toolbar_actions_bar_bubble_delegate.h ('k') | chrome/browser/ui/views/extensions/extension_message_bubble_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/toolbar/toolbar_actions_bar_delegate.h

diff --git a/chrome/browser/ui/toolbar/toolbar_actions_bar_delegate.h b/chrome/browser/ui/toolbar/toolbar_actions_bar_delegate.h

index a226d147a226130860b37a87121fb422c37fa99e..939c809052284bd216b1586f58a6adb9a0b7a629 100644

--- a/chrome/browser/ui/toolbar/toolbar_actions_bar_delegate.h

+++ b/chrome/browser/ui/toolbar/toolbar_actions_bar_delegate.h

@@ -66,14 +66,8 @@ class ToolbarActionsBarDelegate {

// Returns the width (including padding) for the overflow chevron.

virtual int GetChevronWidth() const = 0;

- // Displays the bubble for the passed ExtensionMessageBubbleController,

- // anchored to |anchor_action|. If |anchor_action| is null, it should be

- // anchored to the hotdog menu.

- virtual void ShowExtensionMessageBubble(

- std::unique_ptr<extensions::ExtensionMessageBubbleController> controller,

- ToolbarActionViewController* anchor_action) = 0;

- // Shows the given |bubble| if no other bubbles are showing.

+ // Shows the given |bubble|. Must not be called if another bubble is showing

+ // or if the toolbar is animating.

virtual void ShowToolbarActionBubble(

std::unique_ptr<ToolbarActionsBarBubbleDelegate> bubble) = 0;

};