[Extensions UI] Use the ExtensionMessageBubbleBridge for Views platforms

chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/extensions/browser_actions_controller.h"
 
 #include <stddef.h>
 
 #include <string>
 #include <utility>
 
 #include "base/macros.h"
 #include "base/strings/sys_string_conversions.h"
 #include "chrome/browser/extensions/extension_message_bubble_controller.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_window.h"
 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
 #import "chrome/browser/ui/cocoa/extensions/browser_action_button.h"
 #import "chrome/browser/ui/cocoa/extensions/browser_actions_container_view.h"
-#import "chrome/browser/ui/cocoa/extensions/extension_message_bubble_bridge.h"
 #import "chrome/browser/ui/cocoa/extensions/extension_popup_controller.h"
 #import "chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.h"
 #import "chrome/browser/ui/cocoa/image_button_cell.h"
 #import "chrome/browser/ui/cocoa/menu_button.h"
 #import "chrome/browser/ui/cocoa/toolbar/toolbar_controller.h"
+#include "chrome/browser/ui/extensions/extension_message_bubble_bridge.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/browser/ui/toolbar/toolbar_action_view_controller.h"
 #include "chrome/browser/ui/toolbar/toolbar_actions_bar.h"
 #include "chrome/browser/ui/toolbar/toolbar_actions_bar_delegate.h"
 #include "grit/theme_resources.h"
 #import "third_party/google_toolbox_for_mac/src/AppKit/GTMNSAnimation+Duration.h"
 #include "ui/base/cocoa/appkit_utils.h"
 #include "ui/base/cocoa/cocoa_base_utils.h"
 #include "ui/base/material_design/material_design_controller.h"
 
@@ skipping 120 matching lines @@
 
 // Handles when a menu item within the chevron overflow menu is selected.
 - (void)chevronItemSelected:(id)menuItem;
 
 // Updates the container's grippy cursor based on the number of hidden buttons.
 - (void)updateGrippyCursors;
 
 // Returns the associated ToolbarController.
 - (ToolbarController*)toolbarController;
 
-// Creates a message bubble with the given |delegate| that is anchored to the
-// given |anchorView|.
-- (ToolbarActionsBarBubbleMac*)
-createMessageBubble:(std::unique_ptr<ToolbarActionsBarBubbleDelegate>)delegate
-         anchorView:(NSView*)anchorView;
+// Creates a message bubble with the given |delegate|.
+- (void)createMessageBubble:
+    (std::unique_ptr<ToolbarActionsBarBubbleDelegate>)delegate;
 
 // Called when the window for the active bubble is closing, and sets the active
 // bubble to nil.
 - (void)bubbleWindowClosing:(NSNotification*)notification;
 
 // Sets the current focused view. Should only be used for the overflow
 // container.
 - (void)setFocusedViewIndex:(NSInteger)index;
 
 @end
@@ skipping 28 matching lines @@
   void RemoveAllViews() override;
   void Redraw(bool order_changed) override;
   void ResizeAndAnimate(gfx::Tween::Type tween_type,
                         int target_width,
                         bool suppress_chevron) override;
   void SetChevronVisibility(bool chevron_visible) override;
   int GetWidth(GetWidthTime get_width_time) const override;
   bool IsAnimating() const override;
   void StopAnimating() override;
   int GetChevronWidth() const override;
-  void ShowExtensionMessageBubble(
-      std::unique_ptr<extensions::ExtensionMessageBubbleController> controller,
-      ToolbarActionViewController* anchor_action) override;
   void ShowToolbarActionBubble(
       std::unique_ptr<ToolbarActionsBarBubbleDelegate> bubble) override;
 
   // The owning BrowserActionsController; weak.
   BrowserActionsController* controller_;
 
   DISALLOW_COPY_AND_ASSIGN(ToolbarActionsBarBridge);
 };
 
 ToolbarActionsBarBridge::ToolbarActionsBarBridge(
@@ skipping 53 matching lines @@
   // instead of just ending the animation, the cleanest way to terminate is to
   // "animate" to the current frame.
   [controller_ resizeContainerToWidth:
       NSWidth([[controller_ containerView] frame])];
 }
 
 int ToolbarActionsBarBridge::GetChevronWidth() const {
   return kChevronWidth;
 }
 
-void ToolbarActionsBarBridge::ShowExtensionMessageBubble(
-    std::unique_ptr<extensions::ExtensionMessageBubbleController>
-        bubble_controller,
-    ToolbarActionViewController* anchor_action) {
-  NSView* anchorView = nil;
-  BOOL anchoredToAction = NO;
-  if (anchor_action) {
-    BrowserActionButton* actionButton =
-        [controller_ buttonForId:anchor_action->GetId()];
-    if (actionButton && [actionButton superview]) {
-      anchorView = actionButton;
-      anchoredToAction = YES;
-    }
-  }
-  if (!anchorView)
-    anchorView = [[controller_ toolbarController] appMenuButton];
-
-  // This goop is a by-product of needing to wire together abstract classes,
-  // C++/Cocoa bridges, and ExtensionMessageBubbleController's somewhat strange
-  // Show() interface. It's ugly, but it's pretty confined, so it's probably
-  // okay (but if we ever need to expand, it might need to be reconsidered).
-  extensions::ExtensionMessageBubbleController* weak_controller =
-      bubble_controller.get();
-  std::unique_ptr<ExtensionMessageBubbleBridge> bridge(
-      new ExtensionMessageBubbleBridge(std::move(bubble_controller),
-                                       anchoredToAction));
-  ToolbarActionsBarBubbleMac* bubble =
-      [controller_ createMessageBubble:std::move(bridge)
-                            anchorView:anchorView];
-  weak_controller->OnShown();
-  [bubble showWindow:nil];
-}
-
 void ToolbarActionsBarBridge::ShowToolbarActionBubble(
     std::unique_ptr<ToolbarActionsBarBubbleDelegate> bubble) {
-  NSView* anchorView = nil;
-  if (!bubble->GetAnchorActionId().empty()) {
-    BrowserActionButton* button =
-        [controller_ buttonForId:bubble->GetAnchorActionId()];
-    anchorView = button && [button superview] ? button :
-        [[controller_ toolbarController] appMenuButton];
-  } else {
-    anchorView = [controller_ containerView];
-  }
-
-  ToolbarActionsBarBubbleMac* bubbleView =
-      [controller_ createMessageBubble:std::move(bubble)
-                            anchorView:anchorView];
-  [bubbleView showWindow:nil];
+  [controller_ createMessageBubble:std::move(bubble)];
 }
 
 }  // namespace
 
 @implementation BrowserActionsController
 
 @synthesize containerView = containerView_;
 @synthesize browser = browser_;
 @synthesize isOverflow = isOverflow_;
 @synthesize activeBubble = activeBubble_;
@@ skipping 685 matching lines @@
       setCanDragLeft:toolbarActionsBar_->GetIconCount() != [buttons_ count]];
   [containerView_ setCanDragRight:[self visibleButtonCount] > 0];
   [[containerView_ window] invalidateCursorRectsForView:containerView_];
 }
 
 - (ToolbarController*)toolbarController {
   return [[BrowserWindowController browserWindowControllerForWindow:
              browser_->window()->GetNativeWindow()] toolbarController];
 }
 
-- (ToolbarActionsBarBubbleMac*)
-createMessageBubble:(std::unique_ptr<ToolbarActionsBarBubbleDelegate>)delegate
-         anchorView:(NSView*)anchorView {
-  DCHECK(anchorView);
+- (void)createMessageBubble:
+    (std::unique_ptr<ToolbarActionsBarBubbleDelegate>)delegate {
+  NSView* anchorView = nil;
+  BOOL anchoredToAction = NO;
+  if (!delegate->GetAnchorActionId().empty()) {
+    BrowserActionButton* button =
+        [self buttonForId:delegate->GetAnchorActionId()];
+    if (button && [button superview]) {
+      anchorView = button;
+      anchoredToAction = YES;
+    } else {
+      anchorView = [[self toolbarController] appMenuButton];
+    }
+  } else {
+    anchorView = containerView_;
+  }
+
   DCHECK_GE([buttons_ count], 0u);
   NSPoint anchor = [self popupPointForView:anchorView
                                 withBounds:[anchorView bounds]];
 
   anchor = ui::ConvertPointFromWindowToScreen([containerView_ window], anchor);
   activeBubble_ = [[ToolbarActionsBarBubbleMac alloc]
       initWithParentWindow:[containerView_ window]
                anchorPoint:anchor
+          anchoredToAction:anchoredToAction
                   delegate:std::move(delegate)];
   [[NSNotificationCenter defaultCenter]
       addObserver:self
          selector:@selector(bubbleWindowClosing:)
              name:NSWindowWillCloseNotification
            object:[activeBubble_ window]];
-  return activeBubble_;
+  [activeBubble_ showWindow:nil];
 }
 
 - (void)bubbleWindowClosing:(NSNotification*)notification {
   activeBubble_ = nil;
+  toolbarActionsBar_->OnBubbleClosed();
 }
 
 - (void)setFocusedViewIndex:(NSInteger)index {
   DCHECK(isOverflow_);
   focusedViewIndex_ = index;
 }
 
 #pragma mark -
 #pragma mark Testing Methods
 
 - (BrowserActionButton*)buttonWithIndex:(NSUInteger)index {
   return index < [buttons_ count] ? [buttons_ objectAtIndex:index] : nil;
 }
 
 @end