Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1375)

Unified Diff: chrome/browser/ui/toolbar/toolbar_actions_bar_bubble_delegate.h

Issue 1858773006: [Extensions UI] Use the ExtensionMessageBubbleBridge for Views platforms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/toolbar/toolbar_actions_bar_bubble_delegate.h
diff --git a/chrome/browser/ui/toolbar/toolbar_actions_bar_bubble_delegate.h b/chrome/browser/ui/toolbar/toolbar_actions_bar_bubble_delegate.h
index d07dc71aff076df4a54f5aebf9587845dc7748b7..88f5f1cb3b89dc6551d79229eaf1283d86d638ca 100644
--- a/chrome/browser/ui/toolbar/toolbar_actions_bar_bubble_delegate.h
+++ b/chrome/browser/ui/toolbar/toolbar_actions_bar_bubble_delegate.h
@@ -21,11 +21,21 @@ class ToolbarActionsBarBubbleDelegate {
virtual ~ToolbarActionsBarBubbleDelegate() {}
+ // Returns true if the bubble should (still) be shown. Since bubbles are
+ // sometimes shown asynchronously, they may be invalid by the time they would
+ // be displayed.
+ virtual bool ShouldShow() = 0;
+
+ // Returns true if the bubble should close on deactivation.
+ virtual bool ShouldCloseOnDeactivate() = 0;
+
// Gets the text for the bubble's heading (title).
virtual base::string16 GetHeadingText() = 0;
// Gets the text for the bubble's body.
- virtual base::string16 GetBodyText() = 0;
+ // |anchored_to_action| is true if the bubble is being anchored to a specific
+ // action (rather than the overflow menu or the full container).
+ virtual base::string16 GetBodyText(bool anchored_to_action) = 0;
// Gets the text for an optional item list to display. If this returns an
// empty string, no list will be added.
@@ -54,6 +64,10 @@ class ToolbarActionsBarBubbleDelegate {
// Called when the bubble is closed with the type of action the user took.
virtual void OnBubbleClosed(CloseAction action) = 0;
+
+ // Returns true if this is for an ExtensionMessageBubbleController.
+ // TODO(devlin): We shouldn't need this.
+ virtual bool IsExtensionMessageBubble() = 0;
};
#endif // CHROME_BROWSER_UI_TOOLBAR_TOOLBAR_ACTIONS_BAR_BUBBLE_DELEGATE_H_
« no previous file with comments | « chrome/browser/ui/toolbar/toolbar_actions_bar.cc ('k') | chrome/browser/ui/toolbar/toolbar_actions_bar_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698