[Extensions UI] Use the ExtensionMessageBubbleBridge for Views platforms

chrome/browser/ui/views/toolbar/browser_actions_container.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/toolbar/browser_actions_container.h"
 
 #include <utility>
 
 #include "base/compiler_specific.h"
 #include "base/stl_util.h"
@@ skipping 291 matching lines @@
 
 int BrowserActionsContainer::GetChevronWidth() const {
   return chevron_ ?
       chevron_->GetPreferredSize().width() + GetChevronSpacing() : 0;
 }
 
 void BrowserActionsContainer::ShowToolbarActionBubble(
     std::unique_ptr<ToolbarActionsBarBubbleDelegate> controller) {
   // The container shouldn't be asked to show a bubble if it's animating.
   DCHECK(!animating());
+  DCHECK(!active_bubble_);
+
   views::View* anchor_view = nullptr;
   if (!controller->GetAnchorActionId().empty()) {
     ToolbarActionView* action_view =
         GetViewForId(controller->GetAnchorActionId());
-    anchor_view =
-        action_view->visible() ? action_view : GetOverflowReferenceView();
+    if (action_view) {
+      anchor_view =
+          action_view->visible() ? action_view : GetOverflowReferenceView();
+    } else {
+      anchor_view = BrowserView::GetBrowserViewForBrowser(browser_)
+                        ->toolbar()
+                        ->app_menu_button();
+    }
   } else {
     anchor_view = this;
   }
-  ToolbarActionsBarBubbleViews* bubble =
-      new ToolbarActionsBarBubbleViews(anchor_view, std::move(controller));
-  views::BubbleDelegateView::CreateBubble(bubble);
-  bubble->Show();
-}
 
-void BrowserActionsContainer::ShowExtensionMessageBubble(
-    std::unique_ptr<extensions::ExtensionMessageBubbleController> controller,
-    ToolbarActionViewController* anchor_action) {
-  // The container shouldn't be asked to show a bubble if it's animating.
-  DCHECK(!animating());
-
-  views::View* reference_view =
-      anchor_action
-          ? static_cast<views::View*>(GetViewForId(anchor_action->GetId()))
-          : BrowserView::GetBrowserViewForBrowser(browser_)
-                ->toolbar()
-                ->app_menu_button();
-
-  extensions::ExtensionMessageBubbleView* bubble =
-      new extensions::ExtensionMessageBubbleView(reference_view,
-                                                 views::BubbleBorder::TOP_RIGHT,
-                                                 std::move(controller));
-  views::BubbleDelegateView::CreateBubble(bubble);
-  active_bubble_ = bubble;
-  active_bubble_->GetWidget()->AddObserver(this);
-  bubble->Show();
+  // TODO(devlin): Clean up this type-specific mess.
+  if (controller->IsExtensionMessageBubble()) {

[Devlin, 2016/04/09 01:29:20]

This is quite temporary - I have a followup patch to make
ToolbarActionsBarBubbleViews do the work that ExtensionMessageBubbleView does
now.

+    extensions::ExtensionMessageBubbleView* bubble =
+        new extensions::ExtensionMessageBubbleView(
+            anchor_view, views::BubbleBorder::TOP_RIGHT, std::move(controller));
+    views::BubbleDelegateView::CreateBubble(bubble);
+    active_bubble_ = bubble;
+    active_bubble_->GetWidget()->AddObserver(this);
+    bubble->Show();
+  } else {
+    ToolbarActionsBarBubbleViews* bubble =
+        new ToolbarActionsBarBubbleViews(anchor_view, std::move(controller));
+    views::BubbleDelegateView::CreateBubble(bubble);
+    active_bubble_ = bubble;
+    active_bubble_->GetWidget()->AddObserver(this);
+    bubble->Show();
+  }
 }
 
 void BrowserActionsContainer::OnWidgetClosing(views::Widget* widget) {
   ClearActiveBubble(widget);
 }
 
 void BrowserActionsContainer::OnWidgetDestroying(views::Widget* widget) {
   ClearActiveBubble(widget);
 }
 
@@ skipping 401 matching lines @@
   const int kWarningImages[] = IMAGE_GRID(IDR_DEVELOPER_MODE_HIGHLIGHT);
   warning_highlight_painter_.reset(
       views::Painter::CreateImageGridPainter(kWarningImages));
 }
 
 void BrowserActionsContainer::ClearActiveBubble(views::Widget* widget) {
   DCHECK(active_bubble_);
   DCHECK_EQ(active_bubble_->GetWidget(), widget);
   widget->RemoveObserver(this);
   active_bubble_ = nullptr;
+  toolbar_actions_bar_->OnBubbleClosed();
 }