chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.h - Issue 1858773006: [Extensions UI] Use the ExtensionMessageBubbleBridge for Views platforms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.h

Issue 1858773006: [Extensions UI] Use the ExtensionMessageBubbleBridge for Views platforms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_message_bubble_bridge.mm ('k') | chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.h

diff --git a/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.h b/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.h

index 3b077b2622c6075149883d12d71e49192b0eb236..ffc67c1419a8b61e18f6f0f1a73e446d1a004257 100644

--- a/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.h

+++ b/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.h

@@ -20,6 +20,9 @@ class ToolbarActionsBarBubbleDelegate;

// Whether or not the bubble has been acknowledged.

BOOL acknowledged_;

+ // True if the bubble is anchored to an action in the toolbar actions bar.

+ BOOL anchoredToAction_;

// The action button. The exact meaning of this is dependent on the bubble.

// Required.

NSButton* actionButton_;

@@ -40,6 +43,7 @@ class ToolbarActionsBarBubbleDelegate;

// Creates the bubble for a parent window but does not show it.

- (id)initWithParentWindow:(NSWindow*)parentWindow

anchorPoint:(NSPoint)anchorPoint

+ anchoredToAction:(BOOL)anchoredToAction

delegate:(std::unique_ptr<ToolbarActionsBarBubbleDelegate>)

delegate;