chrome/browser/ui/extensions/blocked_action_bubble_delegate.h - Issue 1858773006: [Extensions UI] Use the ExtensionMessageBubbleBridge for Views platforms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/extensions/blocked_action_bubble_delegate.h

Issue 1858773006: [Extensions UI] Use the ExtensionMessageBubbleBridge for Views platforms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac_unittest.mm ('k') | chrome/browser/ui/extensions/blocked_action_bubble_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/extensions/blocked_action_bubble_delegate.h

diff --git a/chrome/browser/ui/extensions/blocked_action_bubble_delegate.h b/chrome/browser/ui/extensions/blocked_action_bubble_delegate.h

index 8e2200e1c6d357ee002769dcc03b29e692ca4a9d..20e9421a1634f93033c5cfedf317aae9e47cbe0a 100644

--- a/chrome/browser/ui/extensions/blocked_action_bubble_delegate.h

+++ b/chrome/browser/ui/extensions/blocked_action_bubble_delegate.h

@@ -19,8 +19,10 @@ class BlockedActionBubbleDelegate : public ToolbarActionsBarBubbleDelegate {

private:

// ToolbarActionsBarBubbleDelegate:

+ bool ShouldShow() override;

+ bool ShouldCloseOnDeactivate() override;

base::string16 GetHeadingText() override;

- base::string16 GetBodyText() override;

+ base::string16 GetBodyText(bool anchored_to_action) override;

base::string16 GetItemListText() override;

base::string16 GetActionButtonText() override;

base::string16 GetDismissButtonText() override;

@@ -28,6 +30,7 @@ class BlockedActionBubbleDelegate : public ToolbarActionsBarBubbleDelegate {

std::string GetAnchorActionId() override;

void OnBubbleShown() override;

void OnBubbleClosed(CloseAction action) override;

+ bool IsExtensionMessageBubble() override;

base::Callback<void(CloseAction)> callback_;

std::string extension_id_;