Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: chrome/browser/ui/views/settings_api_bubble_helper_views.cc

Issue 1858773006: [Extensions UI] Use the ExtensionMessageBubbleBridge for Views platforms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/settings_api_bubble_helper_views.cc
diff --git a/chrome/browser/ui/views/settings_api_bubble_helper_views.cc b/chrome/browser/ui/views/settings_api_bubble_helper_views.cc
index b2be51e342402cd22d03267b8bb512cd100bcca9..feefb87197b12e785770e32556e7a1b19011a5e3 100644
--- a/chrome/browser/ui/views/settings_api_bubble_helper_views.cc
+++ b/chrome/browser/ui/views/settings_api_bubble_helper_views.cc
@@ -11,6 +11,7 @@
#include "chrome/browser/extensions/settings_api_bubble_delegate.h"
#include "chrome/browser/extensions/settings_api_helpers.h"
#include "chrome/browser/ui/browser_finder.h"
+#include "chrome/browser/ui/extensions/extension_message_bubble_bridge.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/browser/ui/views/extensions/extension_message_bubble_view.h"
#include "chrome/browser/ui/views/frame/browser_view.h"
@@ -37,7 +38,9 @@ void ShowSettingsApiBubble(SettingsApiOverrideType type,
return;
ExtensionMessageBubbleView* bubble = new ExtensionMessageBubbleView(
- anchor_view, arrow, std::move(settings_api_bubble));
+ anchor_view, arrow,
+ std::unique_ptr<ToolbarActionsBarBubbleDelegate>(
+ new ExtensionMessageBubbleBridge(std::move(settings_api_bubble))));
views::BubbleDelegateView::CreateBubble(bubble);
bubble->Show();
}
@@ -111,7 +114,9 @@ void MaybeShowExtensionControlledNewTabPage(
BrowserView::GetBrowserViewForBrowser(browser)
->toolbar()
->app_menu_button(),
- views::BubbleBorder::TOP_RIGHT, std::move(ntp_overridden_bubble));
+ views::BubbleBorder::TOP_RIGHT,
+ std::unique_ptr<ToolbarActionsBarBubbleDelegate>(
+ new ExtensionMessageBubbleBridge(std::move(ntp_overridden_bubble))));
views::BubbleDelegateView::CreateBubble(bubble);
bubble->Show();
}

Powered by Google App Engine
This is Rietveld 408576698