Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5862)

Unified Diff: chrome/browser/ui/extensions/blocked_action_bubble_delegate.cc

Issue 1858773006: [Extensions UI] Use the ExtensionMessageBubbleBridge for Views platforms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/extensions/blocked_action_bubble_delegate.cc
diff --git a/chrome/browser/ui/extensions/blocked_action_bubble_delegate.cc b/chrome/browser/ui/extensions/blocked_action_bubble_delegate.cc
index 288ffef57667ade236aa921650e7c07de0bfa9b2..ad815459017fd95106ffa4f2c31d5096cd5f61cd 100644
--- a/chrome/browser/ui/extensions/blocked_action_bubble_delegate.cc
+++ b/chrome/browser/ui/extensions/blocked_action_bubble_delegate.cc
@@ -16,11 +16,22 @@ BlockedActionBubbleDelegate::BlockedActionBubbleDelegate(
BlockedActionBubbleDelegate::~BlockedActionBubbleDelegate() {}
+bool BlockedActionBubbleDelegate::ShouldShow() {
+ // TODO(devlin): Technically, this could be wrong if the extension no longer
+ // wants to run, was unloaded, etc. We should update this.
+ return true;
+}
+
+bool BlockedActionBubbleDelegate::ShouldCloseOnDeactivate() {
+ return true;
+}
+
base::string16 BlockedActionBubbleDelegate::GetHeadingText() {
return l10n_util::GetStringUTF16(IDS_EXTENSION_BLOCKED_ACTION_BUBBLE_HEADING);
}
-base::string16 BlockedActionBubbleDelegate::GetBodyText() {
+base::string16 BlockedActionBubbleDelegate::GetBodyText(
+ bool anchored_to_action) {
return l10n_util::GetStringUTF16(IDS_EXTENSION_BLOCKED_ACTION_BUBBLE_CONTENT);
}
@@ -51,3 +62,7 @@ void BlockedActionBubbleDelegate::OnBubbleShown() {}
void BlockedActionBubbleDelegate::OnBubbleClosed(CloseAction action) {
base::ResetAndReturn(&callback_).Run(action);
}
+
+bool BlockedActionBubbleDelegate::IsExtensionMessageBubble() {
+ return false;
+}

Powered by Google App Engine
This is Rietveld 408576698