Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC.

Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC.

Having this happen implicitly can be dangerous because the lifetime
has to be considered; we should have caught the "red bots" in
https://codereview.chromium.org/1847333004/#ps60001 at compile time.

Committed: https://pdfium.googlesource.com/pdfium/+/28f97ff783c16f3391384ce97b765ce4eb310ac7

[Tom Sepez, 2016-04-04 19:14:45]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-04-04 19:14:46]

Lei, for review, when you get a chance.  Thanks.

[Lei Zhang, 2016-04-04 22:11:29]

Needs a bit more work to get the trybots green.

https://codereview.chromium.org/1853233002/diff/20001/core/fpdfdoc/doc_form.cpp
File core/fpdfdoc/doc_form.cpp (right):

https://codereview.chromium.org/1853233002/diff/20001/core/fpdfdoc/doc_form.c...
core/fpdfdoc/doc_form.cpp:346: if (!pDict->KeyExist((csTmp +
bsNum).AsByteStringC())) {
Save the resulting CFX_ByteString so you don't need to compute it again on the
next line?

[Tom Sepez, 2016-04-04 22:54:39]

https://codereview.chromium.org/1853233002/diff/20001/core/fpdfdoc/doc_form.cpp
File core/fpdfdoc/doc_form.cpp (right):

https://codereview.chromium.org/1853233002/diff/20001/core/fpdfdoc/doc_form.c...
core/fpdfdoc/doc_form.cpp:346: if (!pDict->KeyExist((csTmp +
bsNum).AsByteStringC())) {
On 2016/04/04 22:11:29, Lei Zhang wrote:
> Save the resulting CFX_ByteString so you don't need to compute it again on the
> next line?

Done.

[Lei Zhang, 2016-04-04 22:59:04]

lgtm

https://codereview.chromium.org/1853233002/diff/40001/core/fpdfapi/fpdf_parse...
File core/fpdfapi/fpdf_parser/cpdf_string.cpp (right):

https://codereview.chromium.org/1853233002/diff/40001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/cpdf_string.cpp:35: return m_String.AsByteStringC();
Fix CPDF_Name::GetConstString() as well?

[Tom Sepez, 2016-04-04 23:24:28]

https://codereview.chromium.org/1853233002/diff/40001/core/fpdfapi/fpdf_parse...
File core/fpdfapi/fpdf_parser/cpdf_string.cpp (right):

https://codereview.chromium.org/1853233002/diff/40001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/cpdf_string.cpp:35: return m_String.AsByteStringC();
On 2016/04/04 22:59:04, Lei Zhang wrote:
> Fix CPDF_Name::GetConstString() as well?
Good idea. done.

[Tom Sepez, 2016-04-04 23:24:34]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-04-04 23:24:35]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1853233002/#ps100001
(title: "Fix CPDF_Name::GetConstString()")

[commit-bot: I haz the power, 2016-04-04 23:24:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1853233002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1853233002/100001

[commit-bot: I haz the power, 2016-04-04 23:41:39]

Description was changed from

==========
Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC.

Having this happen implicitly can be dangerous because the lifetime
has to be considered; we should have caught the "red bots" in
https://codereview.chromium.org/1847333004/#ps60001 at compile time.
==========

to

==========
Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC.

Having this happen implicitly can be dangerous because the lifetime
has to be considered; we should have caught the "red bots" in
https://codereview.chromium.org/1847333004/#ps60001 at compile time.

Committed:
https://pdfium.googlesource.com/pdfium/+/28f97ff783c16f3391384ce97b765ce4eb31...
==========

[commit-bot: I haz the power, 2016-04-04 23:41:40]

Committed patchset #6 (id:100001) as
https://pdfium.googlesource.com/pdfium/+/28f97ff783c16f3391384ce97b765ce4eb31...