core/fpdfapi/fpdf_parser/include/cpdf_object.h - Issue 1853233002: Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_parser/include/cpdf_object.h

Issue 1853233002: Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Fix CPDF_Name::GetConstString() Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/fpdfapi/fpdf_parser/include/cpdf_object.h

diff --git a/core/fpdfapi/fpdf_parser/include/cpdf_object.h b/core/fpdfapi/fpdf_parser/include/cpdf_object.h

index 802cbbc63893c2e5b19b86c933cded9852823014..6cdaaf58fd8c5af07c2b0de61c2687dcf19c04ab 100644

--- a/core/fpdfapi/fpdf_parser/include/cpdf_object.h

+++ b/core/fpdfapi/fpdf_parser/include/cpdf_object.h

@@ -46,6 +46,8 @@ class CPDF_Object {

void Release();

virtual CFX_ByteString GetString() const;

+ // Note: |this| must outlive the use of |GetConstString|'s result.

virtual CFX_ByteStringC GetConstString() const;

virtual CFX_WideString GetUnicodeText() const;

virtual FX_FLOAT GetNumber() const;

« no previous file with comments | « core/fpdfapi/fpdf_parser/cpdf_syntax_parser.cpp ('k') | core/fpdfdoc/cpvt_color.cpp » ('j') | no next file with comments »