xfa/fxfa/app/xfa_fontmgr.cpp - Issue 1853233002: Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/app/xfa_fontmgr.cpp

Issue 1853233002: Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Fix CPDF_Name::GetConstString() Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: xfa/fxfa/app/xfa_fontmgr.cpp

diff --git a/xfa/fxfa/app/xfa_fontmgr.cpp b/xfa/fxfa/app/xfa_fontmgr.cpp

index e915dcbaf78a196e3ed6df2a055e049e5db7da9c..b9cfd6fb284fe3012a28557ab6d06fd7be045db1 100644

--- a/xfa/fxfa/app/xfa_fontmgr.cpp

+++ b/xfa/fxfa/app/xfa_fontmgr.cpp

@@ -1861,7 +1861,8 @@ IFX_Font* CXFA_PDFFontMgr::FindFont(CFX_ByteString strPsName,

for (const auto& it : *pFontSetDict) {

const CFX_ByteString& key = it.first;

CPDF_Object* pObj = it.second;

- if (!PsNameMatchDRFontName(strPsName, bBold, bItalic, key, bStrictMatch)) {

+ if (!PsNameMatchDRFontName(strPsName.AsByteStringC(), bBold, bItalic, key,

+ bStrictMatch)) {

continue;

}

CPDF_Object* pDirect = pObj->GetDirect();

« no previous file with comments | « xfa/fxfa/app/xfa_fftextedit.cpp ('k') | xfa/fxfa/fm2js/xfa_fm2jscontext.cpp » ('j') | no next file with comments »