core/fxcrt/fx_basic_buffer.cpp - Issue 1853233002: Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxcrt/fx_basic_buffer.cpp

Issue 1853233002: Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Fix CPDF_Name::GetConstString() Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/fxcrt/fx_basic_buffer.cpp

diff --git a/core/fxcrt/fx_basic_buffer.cpp b/core/fxcrt/fx_basic_buffer.cpp

index 28c8ac0f3271bce3ddfb210e12b7dc35375feeaa..de7bff24018284e717af3ccf769f2859f5e431b4 100644

--- a/core/fxcrt/fx_basic_buffer.cpp

+++ b/core/fxcrt/fx_basic_buffer.cpp

@@ -248,7 +248,7 @@ CFX_ArchiveSaver& CFX_ArchiveSaver::operator<<(const FX_WCHAR* wstr) {

}

CFX_ArchiveSaver& CFX_ArchiveSaver::operator<<(const CFX_WideString& wstr) {

CFX_ByteString encoded = wstr.UTF16LE_Encode();

- return operator<<(encoded);

+ return operator<<(encoded.AsByteStringC());

}

void CFX_ArchiveSaver::Write(const void* pData, FX_STRSIZE dwSize) {

if (m_pStream) {

« no previous file with comments | « core/fpdfdoc/doc_utils.cpp ('k') | core/fxcrt/fx_xml_parser.cpp » ('j') | no next file with comments »