core/fpdfdoc/doc_form.cpp - Issue 1853233002: Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfdoc/doc_form.cpp

Issue 1853233002: Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Fix CPDF_Name::GetConstString() Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/fpdfdoc/doc_form.cpp

diff --git a/core/fpdfdoc/doc_form.cpp b/core/fpdfdoc/doc_form.cpp

index 2a6d7395493f96e9b0ebcea6e825090e47dd9ab0..aa4b5c9f3069e7c9667530317411714f7f33f547 100644

--- a/core/fpdfdoc/doc_form.cpp

+++ b/core/fpdfdoc/doc_form.cpp

@@ -343,8 +343,9 @@ CFX_ByteString CPDF_InterForm::GenerateNewResourceName(

int num = 0;

CFX_ByteString bsNum;

while (TRUE) {

- if (!pDict->KeyExist(csTmp + bsNum)) {

- return csTmp + bsNum;

+ CFX_ByteString csKey = csTmp + bsNum;

+ if (!pDict->KeyExist(csKey.AsByteStringC())) {

+ return csKey;

}

if (m < iCount) {

csTmp += csStr[m++];

« no previous file with comments | « core/fpdfdoc/doc_bookmark.cpp ('k') | core/fpdfdoc/doc_formcontrol.cpp » ('j') | no next file with comments »