core/fxcrt/fxcrt_posix.cpp - Issue 1853233002: Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxcrt/fxcrt_posix.cpp

Issue 1853233002: Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Fix CPDF_Name::GetConstString() Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/fxcrt/fxcrt_posix.cpp

diff --git a/core/fxcrt/fxcrt_posix.cpp b/core/fxcrt/fxcrt_posix.cpp

index 2f17e71567c70dea87bf664e08f367c1b99c1430..0226313934cd0f35243a5874d133029ca7d34fab 100644

--- a/core/fxcrt/fxcrt_posix.cpp

+++ b/core/fxcrt/fxcrt_posix.cpp

@@ -45,7 +45,7 @@ FX_BOOL CFXCRT_FileAccess_Posix::Open(const CFX_ByteStringC& fileName,

}

FX_BOOL CFXCRT_FileAccess_Posix::Open(const CFX_WideStringC& fileName,

uint32_t dwMode) {

- return Open(FX_UTF8Encode(fileName), dwMode);

+ return Open(FX_UTF8Encode(fileName).AsByteStringC(), dwMode);

}

void CFXCRT_FileAccess_Posix::Close() {

if (m_nFD < 0) {

« no previous file with comments | « core/fxcrt/fx_xml_parser.cpp ('k') | core/fxcrt/include/fx_basic.h » ('j') | no next file with comments »