core/fpdfdoc/doc_action.cpp - Issue 1853233002: Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfdoc/doc_action.cpp

Issue 1853233002: Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Fix CPDF_Name::GetConstString() Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/fpdfdoc/doc_action.cpp

diff --git a/core/fpdfdoc/doc_action.cpp b/core/fpdfdoc/doc_action.cpp

index 2f08bfa3afb3b4719082974c910971666e11fcdf..9a43b58e9815a3bb3951e9529e277e937abe241d 100644

--- a/core/fpdfdoc/doc_action.cpp

+++ b/core/fpdfdoc/doc_action.cpp

@@ -38,8 +38,8 @@ CPDF_Dest CPDF_Action::GetDest(CPDF_Document* pDoc) const {

}

if (pDest->IsString() || pDest->IsName()) {

CPDF_NameTree name_tree(pDoc, "Dests");

- CFX_ByteStringC name = pDest->GetString();

- return CPDF_Dest(name_tree.LookupNamedDest(pDoc, name));

+ return CPDF_Dest(

+ name_tree.LookupNamedDest(pDoc, pDest->GetString().AsByteStringC()));

}

if (CPDF_Array* pArray = pDest->AsArray())

return CPDF_Dest(pArray);

« no previous file with comments | « core/fpdfdoc/cpvt_generateap.cpp ('k') | core/fpdfdoc/doc_annot.cpp » ('j') | no next file with comments »