Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC.

core/fpdfdoc/doc_basic.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/fpdfapi/fpdf_parser/include/cpdf_array.h"
 #include "core/fpdfapi/fpdf_parser/include/cpdf_document.h"
 #include "core/fpdfdoc/doc_utils.h"
 #include "core/include/fpdfdoc/fpdf_doc.h"
@@ skipping 72 matching lines @@
                                    int& nIndex,
                                    CPDF_Array** ppFind,
                                    int nLevel = 0) {
   if (nLevel > nMaxRecursion) {
     return NULL;
   }
   CPDF_Array* pLimits = pNode->GetArrayBy("Limits");
   if (pLimits) {
     CFX_ByteString csLeft = pLimits->GetStringAt(0);
     CFX_ByteString csRight = pLimits->GetStringAt(1);
-    if (csLeft.Compare(csRight) > 0) {
+    if (csLeft.Compare(csRight.AsByteStringC()) > 0) {
       CFX_ByteString csTmp = csRight;
       csRight = csLeft;
       csLeft = csTmp;
     }
-    if (csName.Compare(csLeft) < 0 || csName.Compare(csRight) > 0) {
+    if (csName.Compare(csLeft.AsByteStringC()) < 0 ||
+        csName.Compare(csRight.AsByteStringC()) > 0) {
       return NULL;
     }
   }
   CPDF_Array* pNames = pNode->GetArrayBy("Names");
   if (pNames) {
     uint32_t dwCount = pNames->GetCount() / 2;
     for (uint32_t i = 0; i < dwCount; i++) {
       CFX_ByteString csValue = pNames->GetStringAt(i * 2);
-      int32_t iCompare = csValue.Compare(csName);
+      int32_t iCompare = csValue.Compare(csName.AsByteStringC());
       if (iCompare <= 0) {
         if (ppFind) {
           *ppFind = pNames;
         }
         if (iCompare < 0) {
           continue;
         }
       } else {
         break;
       }
@@ skipping 375 matching lines @@
   }
   CPDF_Dictionary* pPDFRoot = m_pDocument->GetRoot();
   if (!pPDFRoot) {
     return -1;
   }
   int nPages = m_pDocument->GetPageCount();
   CFX_ByteString bsLbl;
   CFX_ByteString bsOrig = bsLabel;
   for (int i = 0; i < nPages; i++) {
     bsLbl = PDF_EncodeText(GetLabel(i));
-    if (!bsLbl.Compare(bsOrig)) {
+    if (!bsLbl.Compare(bsOrig.AsByteStringC())) {
       return i;
     }
   }
   bsLbl = bsOrig;
   int nPage = FXSYS_atoi(bsLbl);
   if (nPage > 0 && nPage <= nPages) {
     return nPage;
   }
   return -1;
 }
 int32_t CPDF_PageLabel::GetPageByLabel(const CFX_WideStringC& wsLabel) const {
-  CFX_ByteString bsLabel = PDF_EncodeText(wsLabel.GetPtr());
-  return GetPageByLabel(bsLabel);
+  return GetPageByLabel(PDF_EncodeText(wsLabel.GetPtr()).AsByteStringC());
 }