core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp - Issue 1853233002: Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp

Issue 1853233002: Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Fix CPDF_Name::GetConstString() Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp

diff --git a/core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp b/core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp

index 0f75cb04a8fa86143ca361c002cb7b72a3b17b51..d70c04c6904d8edcb89f30422d6cc329712bb2ef 100644

--- a/core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp

+++ b/core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp

@@ -1124,7 +1124,7 @@ CPDF_Font* CPDF_Document::AddStandardFont(const FX_CHAR* font,

CFX_ByteString name(font);

if (PDF_GetStandardFontName(&name) < 0)

return nullptr;

- return GetPageData()->GetStandardFont(name, pEncoding);

+ return GetPageData()->GetStandardFont(name.AsByteStringC(), pEncoding);

}

void CPDF_Document::DeletePage(int iPage) {

« no previous file with comments | « core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp ('k') | core/fpdfapi/fpdf_font/fpdf_font.cpp » ('j') | no next file with comments »