Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC.

core/fpdfdoc/doc_utils.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include <algorithm>
 #include <vector>
 
 #include "core/fpdfapi/fpdf_font/include/cpdf_font.h"
@@ skipping 64 matching lines @@
       }
     }
     pLevel = pLevel->GetDictBy("Parent");
   }
   return full_name;
 }
 FX_BOOL CPDF_DefaultAppearance::HasFont() {
   if (m_csDA.IsEmpty()) {
     return FALSE;
   }
-  CPDF_SimpleParser syntax(m_csDA);
+  CPDF_SimpleParser syntax(m_csDA.AsByteStringC());
   return syntax.FindTagParamFromStart("Tf", 2);
 }
 CFX_ByteString CPDF_DefaultAppearance::GetFontString() {
   CFX_ByteString csFont;
   if (m_csDA.IsEmpty()) {
     return csFont;
   }
-  CPDF_SimpleParser syntax(m_csDA);
+  CPDF_SimpleParser syntax(m_csDA.AsByteStringC());
   if (syntax.FindTagParamFromStart("Tf", 2)) {
     csFont += (CFX_ByteString)syntax.GetWord();
     csFont += " ";
     csFont += (CFX_ByteString)syntax.GetWord();
     csFont += " ";
     csFont += (CFX_ByteString)syntax.GetWord();
   }
   return csFont;
 }
 void CPDF_DefaultAppearance::GetFont(CFX_ByteString& csFontNameTag,
                                      FX_FLOAT& fFontSize) {
   csFontNameTag = "";
   fFontSize = 0;
   if (m_csDA.IsEmpty()) {
     return;
   }
-  CPDF_SimpleParser syntax(m_csDA);
+  CPDF_SimpleParser syntax(m_csDA.AsByteStringC());
   if (syntax.FindTagParamFromStart("Tf", 2)) {
-    csFontNameTag = (CFX_ByteString)syntax.GetWord();
+    csFontNameTag = CFX_ByteString(syntax.GetWord());
     csFontNameTag.Delete(0, 1);
-    fFontSize = FX_atof((CFX_ByteString)syntax.GetWord());
+    fFontSize = FX_atof(syntax.GetWord());
   }
   csFontNameTag = PDF_NameDecode(csFontNameTag);
 }
 FX_BOOL CPDF_DefaultAppearance::HasColor(FX_BOOL bStrokingOperation) {
   if (m_csDA.IsEmpty()) {
     return FALSE;
   }
-  CPDF_SimpleParser syntax(m_csDA);
+  CPDF_SimpleParser syntax(m_csDA.AsByteStringC());
   if (syntax.FindTagParamFromStart(bStrokingOperation ? "G" : "g", 1)) {
     return TRUE;
   }
   if (syntax.FindTagParamFromStart(bStrokingOperation ? "RG" : "rg", 3)) {
     return TRUE;
   }
   return syntax.FindTagParamFromStart(bStrokingOperation ? "K" : "k", 4);
 }
 CFX_ByteString CPDF_DefaultAppearance::GetColorString(
     FX_BOOL bStrokingOperation) {
   CFX_ByteString csColor;
   if (m_csDA.IsEmpty()) {
     return csColor;
   }
-  CPDF_SimpleParser syntax(m_csDA);
+  CPDF_SimpleParser syntax(m_csDA.AsByteStringC());
   if (syntax.FindTagParamFromStart(bStrokingOperation ? "G" : "g", 1)) {
     csColor += (CFX_ByteString)syntax.GetWord();
     csColor += " ";
     csColor += (CFX_ByteString)syntax.GetWord();
     return csColor;
   }
   if (syntax.FindTagParamFromStart(bStrokingOperation ? "RG" : "rg", 3)) {
     csColor += (CFX_ByteString)syntax.GetWord();
     csColor += " ";
     csColor += (CFX_ByteString)syntax.GetWord();
@@ skipping 19 matching lines @@
 void CPDF_DefaultAppearance::GetColor(int& iColorType,
                                       FX_FLOAT fc[4],
                                       FX_BOOL bStrokingOperation) {
   iColorType = COLORTYPE_TRANSPARENT;
   for (int c = 0; c < 4; c++) {
     fc[c] = 0;
   }
   if (m_csDA.IsEmpty()) {
     return;
   }
-  CPDF_SimpleParser syntax(m_csDA);
+  CPDF_SimpleParser syntax(m_csDA.AsByteStringC());
   if (syntax.FindTagParamFromStart(bStrokingOperation ? "G" : "g", 1)) {
     iColorType = COLORTYPE_GRAY;
-    fc[0] = FX_atof((CFX_ByteString)syntax.GetWord());
+    fc[0] = FX_atof(syntax.GetWord());
     return;
   }
   if (syntax.FindTagParamFromStart(bStrokingOperation ? "RG" : "rg", 3)) {
     iColorType = COLORTYPE_RGB;
-    fc[0] = FX_atof((CFX_ByteString)syntax.GetWord());
-    fc[1] = FX_atof((CFX_ByteString)syntax.GetWord());
-    fc[2] = FX_atof((CFX_ByteString)syntax.GetWord());
+    fc[0] = FX_atof(syntax.GetWord());
+    fc[1] = FX_atof(syntax.GetWord());
+    fc[2] = FX_atof(syntax.GetWord());
     return;
   }
   if (syntax.FindTagParamFromStart(bStrokingOperation ? "K" : "k", 4)) {
     iColorType = COLORTYPE_CMYK;
-    fc[0] = FX_atof((CFX_ByteString)syntax.GetWord());
-    fc[1] = FX_atof((CFX_ByteString)syntax.GetWord());
-    fc[2] = FX_atof((CFX_ByteString)syntax.GetWord());
-    fc[3] = FX_atof((CFX_ByteString)syntax.GetWord());
+    fc[0] = FX_atof(syntax.GetWord());
+    fc[1] = FX_atof(syntax.GetWord());
+    fc[2] = FX_atof(syntax.GetWord());
+    fc[3] = FX_atof(syntax.GetWord());
   }
 }
 void CPDF_DefaultAppearance::GetColor(FX_ARGB& color,
                                       int& iColorType,
                                       FX_BOOL bStrokingOperation) {
   color = 0;
   iColorType = COLORTYPE_TRANSPARENT;
   if (m_csDA.IsEmpty()) {
     return;
   }
-  CPDF_SimpleParser syntax(m_csDA);
+  CPDF_SimpleParser syntax(m_csDA.AsByteStringC());
   if (syntax.FindTagParamFromStart(bStrokingOperation ? "G" : "g", 1)) {
     iColorType = COLORTYPE_GRAY;
-    FX_FLOAT g = FX_atof((CFX_ByteString)syntax.GetWord()) * 255 + 0.5f;
+    FX_FLOAT g = FX_atof(syntax.GetWord()) * 255 + 0.5f;
     color = ArgbEncode(255, (int)g, (int)g, (int)g);
     return;
   }
   if (syntax.FindTagParamFromStart(bStrokingOperation ? "RG" : "rg", 3)) {
     iColorType = COLORTYPE_RGB;
-    FX_FLOAT r = FX_atof((CFX_ByteString)syntax.GetWord()) * 255 + 0.5f;
-    FX_FLOAT g = FX_atof((CFX_ByteString)syntax.GetWord()) * 255 + 0.5f;
-    FX_FLOAT b = FX_atof((CFX_ByteString)syntax.GetWord()) * 255 + 0.5f;
+    FX_FLOAT r = FX_atof(syntax.GetWord()) * 255 + 0.5f;
+    FX_FLOAT g = FX_atof(syntax.GetWord()) * 255 + 0.5f;
+    FX_FLOAT b = FX_atof(syntax.GetWord()) * 255 + 0.5f;
     color = ArgbEncode(255, (int)r, (int)g, (int)b);
     return;
   }
   if (syntax.FindTagParamFromStart(bStrokingOperation ? "K" : "k", 4)) {
     iColorType = COLORTYPE_CMYK;
-    FX_FLOAT c = FX_atof((CFX_ByteString)syntax.GetWord());
-    FX_FLOAT m = FX_atof((CFX_ByteString)syntax.GetWord());
-    FX_FLOAT y = FX_atof((CFX_ByteString)syntax.GetWord());
-    FX_FLOAT k = FX_atof((CFX_ByteString)syntax.GetWord());
+    FX_FLOAT c = FX_atof(syntax.GetWord());
+    FX_FLOAT m = FX_atof(syntax.GetWord());
+    FX_FLOAT y = FX_atof(syntax.GetWord());
+    FX_FLOAT k = FX_atof(syntax.GetWord());
     FX_FLOAT r = 1.0f - std::min(1.0f, c + k);
     FX_FLOAT g = 1.0f - std::min(1.0f, m + k);
     FX_FLOAT b = 1.0f - std::min(1.0f, y + k);
     color = ArgbEncode(255, (int)(r * 255 + 0.5f), (int)(g * 255 + 0.5f),
                        (int)(b * 255 + 0.5f));
   }
 }
 FX_BOOL CPDF_DefaultAppearance::HasTextMatrix() {
   if (m_csDA.IsEmpty()) {
     return FALSE;
   }
-  CPDF_SimpleParser syntax(m_csDA);
+  CPDF_SimpleParser syntax(m_csDA.AsByteStringC());
   return syntax.FindTagParamFromStart("Tm", 6);
 }
 CFX_ByteString CPDF_DefaultAppearance::GetTextMatrixString() {
   CFX_ByteString csTM;
   if (m_csDA.IsEmpty()) {
     return csTM;
   }
-  CPDF_SimpleParser syntax(m_csDA);
+  CPDF_SimpleParser syntax(m_csDA.AsByteStringC());
   if (syntax.FindTagParamFromStart("Tm", 6)) {
     for (int i = 0; i < 6; i++) {
       csTM += (CFX_ByteString)syntax.GetWord();
       csTM += " ";
     }
     csTM += (CFX_ByteString)syntax.GetWord();
   }
   return csTM;
 }
 CFX_Matrix CPDF_DefaultAppearance::GetTextMatrix() {
   CFX_Matrix tm;
   if (m_csDA.IsEmpty()) {
     return tm;
   }
-  CPDF_SimpleParser syntax(m_csDA);
+  CPDF_SimpleParser syntax(m_csDA.AsByteStringC());
   if (syntax.FindTagParamFromStart("Tm", 6)) {
     FX_FLOAT f[6];
     for (int i = 0; i < 6; i++) {
-      f[i] = FX_atof((CFX_ByteString)syntax.GetWord());
+      f[i] = FX_atof(syntax.GetWord());
     }
     tm.Set(f[0], f[1], f[2], f[3], f[4], f[5]);
   }
   return tm;
 }
 void InitInterFormDict(CPDF_Dictionary*& pFormDict, CPDF_Document* pDocument) {
   if (!pDocument) {
     return;
   }
   if (!pFormDict) {
@@ skipping 104 matching lines @@
     return NULL;
   }
   CPDF_Dictionary* pDR = pFormDict->GetDictBy("DR");
   if (!pDR) {
     return NULL;
   }
   CPDF_Dictionary* pFonts = pDR->GetDictBy("Font");
   if (!pFonts) {
     return NULL;
   }
-  CPDF_Dictionary* pElement = pFonts->GetDictBy(csAlias);
+  CPDF_Dictionary* pElement = pFonts->GetDictBy(csAlias.AsByteStringC());
   if (!pElement) {
     return NULL;
   }
   if (pElement->GetStringBy("Type") == "Font") {
     return pDocument->LoadFont(pElement);
   }
   return NULL;
 }
 CPDF_Font* GetInterFormFont(CPDF_Dictionary* pFormDict,
                             CPDF_Document* pDocument,
@@ skipping 198 matching lines @@
   if (!pFonts) {
     pFonts = new CPDF_Dictionary;
     pDR->SetAt("Font", pFonts);
   }
   if (csNameTag.IsEmpty()) {
     csNameTag = pFont->GetBaseFont();
   }
   csNameTag.Remove(' ');
   csNameTag =
       CPDF_InterForm::GenerateNewResourceName(pDR, "Font", 4, csNameTag);
-  pFonts->SetAtReference(csNameTag, pDocument, pFont->GetFontDict());
+  pFonts->SetAtReference(csNameTag.AsByteStringC(), pDocument,
+                         pFont->GetFontDict());
 }
 CPDF_Font* AddNativeInterFormFont(CPDF_Dictionary*& pFormDict,
                                   CPDF_Document* pDocument,
                                   uint8_t charSet,
                                   CFX_ByteString& csNameTag) {
   if (!pFormDict) {
     InitInterFormDict(pFormDict, pDocument);
   }
   CFX_ByteString csTemp;
   CPDF_Font* pFont =
@@ skipping 23 matching lines @@
 void RemoveInterFormFont(CPDF_Dictionary* pFormDict, const CPDF_Font* pFont) {
   if (!pFormDict || !pFont) {
     return;
   }
   CFX_ByteString csTag;
   if (!FindInterFormFont(pFormDict, pFont, csTag)) {
     return;
   }
   CPDF_Dictionary* pDR = pFormDict->GetDictBy("DR");
   CPDF_Dictionary* pFonts = pDR->GetDictBy("Font");
-  pFonts->RemoveAt(csTag);
+  pFonts->RemoveAt(csTag.AsByteStringC());
 }
 void RemoveInterFormFont(CPDF_Dictionary* pFormDict, CFX_ByteString csNameTag) {
   if (!pFormDict || csNameTag.IsEmpty()) {
     return;
   }
   CPDF_Dictionary* pDR = pFormDict->GetDictBy("DR");
   if (!pDR) {
     return;
   }
   CPDF_Dictionary* pFonts = pDR->GetDictBy("Font");
   if (!pFonts) {
     return;
   }
-  pFonts->RemoveAt(csNameTag);
+  pFonts->RemoveAt(csNameTag.AsByteStringC());
 }
 
 CPDF_Font* GetDefaultInterFormFont(CPDF_Dictionary* pFormDict,
                                    CPDF_Document* pDocument) {
   if (!pFormDict) {
     return NULL;
   }
   CPDF_DefaultAppearance cDA(pFormDict->GetStringBy("DA"));
   CFX_ByteString csFontNameTag;
   FX_FLOAT fFontSize;
@@ skipping 68 matching lines @@
   CPDF_Object* pAttr = pFieldDict->GetDirectObjectBy(name);
   if (pAttr) {
     return pAttr;
   }
   CPDF_Dictionary* pParent = pFieldDict->GetDictBy("Parent");
   if (!pParent) {
     return NULL;
   }
   return FPDF_GetFieldAttr(pParent, name, nLevel + 1);
 }