Remove WebGraphicsContext3D::getGLES2Interface().

Remove WebGraphicsContext3D::getGLES2Interface().

We no longer have WebGraphicsContext3D without having access to the
actual GLES2Interface anywhere, so we don't need the method. The last
holdout was getAWebGraphicsContext3D() in the WebGLObjects. This
was changed to get a WebGLRenderingContextBase from which it can
get a GLES2Interface, and we remove the unused WebGraphicsContext3D*
plumbing all over them.

R=kbr@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/46070b02edbd8d5531a143612c53f1a77baded40
Cr-Commit-Position: refs/heads/master@{#383576}

[danakj, 2016-03-25 21:58:37]

Description was changed from

==========
Remove WebGraphicsContext3D::getGLES2Interface().

We no longer have WebGraphicsContext3D without having access to the
actual GLES2Interface anywhere, so we don't need the method. The last
holdout was getAWebGraphicsContext3D() in the WebGLObjects. This
was changed to get a WebGLRenderingContextBase from which it can
get a GLES2Interface, and we remove the unused WebGraphicsContext3D*
plumbing all over them.

R=kbr@chromium.org
BUG=584497
==========

to

==========
Remove WebGraphicsContext3D::getGLES2Interface().

We no longer have WebGraphicsContext3D without having access to the
actual GLES2Interface anywhere, so we don't need the method. The last
holdout was getAWebGraphicsContext3D() in the WebGLObjects. This
was changed to get a WebGLRenderingContextBase from which it can
get a GLES2Interface, and we remove the unused WebGraphicsContext3D*
plumbing all over them.

R=kbr@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[danakj, 2016-03-25 21:58:39]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-25 21:59:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1833273002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1833273002/1

[danakj, 2016-03-25 21:59:26]

danakj@chromium.org changed reviewers:
+ chrishtr@chromium.org

[danakj, 2016-03-25 21:59:27]

kbr: everything
chrishtr: public OWNERS

https://codereview.chromium.org/1833273002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGLObject.h (right):

https://codereview.chromium.org/1833273002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGLObject.h:99: virtual
WebGLRenderingContextBase* getAWebGLRenderingContextBase() const = 0;
This could be getAGLES2Interface, but we'd talked about returning a
WebGLRenderingContextBase before, so I did that for now.

[chrishtr, 2016-03-25 22:12:04]

lgtm

[commit-bot: I haz the power, 2016-03-25 22:17:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-25 22:17:40]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[danakj, 2016-03-25 22:27:55]

danakj@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[danakj, 2016-03-25 22:27:56]

Oh, I missed copyVideoTextureToPlatformTexture(), updated that to take
GLES2Interface* as its argument.

+dalecurtis for media stuff.

chrishtr: note new changes in core/

[danakj, 2016-03-25 22:29:26]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-25 22:29:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1833273002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1833273002/20001

[DaleCurtis, 2016-03-25 22:32:01]

media/ lgtm

https://codereview.chromium.org/1833273002/diff/20001/content/renderer/media/...
File content/renderer/media/android/webmediaplayer_android.cc (right):

https://codereview.chromium.org/1833273002/diff/20001/content/renderer/media/...
content/renderer/media/android/webmediaplayer_android.cc:704: // TODO(danakj):
Pass a GLES2Interface to this method instead.
Delete todo?

[danakj, 2016-03-25 22:36:44]

https://codereview.chromium.org/1833273002/diff/20001/content/renderer/media/...
File content/renderer/media/android/webmediaplayer_android.cc (right):

https://codereview.chromium.org/1833273002/diff/20001/content/renderer/media/...
content/renderer/media/android/webmediaplayer_android.cc:704: // TODO(danakj):
Pass a GLES2Interface to this method instead.
On 2016/03/25 22:32:00, DaleCurtis wrote:
> Delete todo?

:D

[Zhenyao Mo, 2016-03-25 23:13:51]

zmo@chromium.org changed reviewers:
+ zmo@chromium.org

[Zhenyao Mo, 2016-03-25 23:13:52]

blink/webgl lgtm

I have one suggestion, but this is a large CL, so you can land as is and do a
followup later.

https://codereview.chromium.org/1833273002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webgl/WebGLContextGroup.h (right):

https://codereview.chromium.org/1833273002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGLContextGroup.h:56:
WebGLRenderingContextBase* getAWebGLRenderingContextBase();
I think here you can return a gpu::gles2::GLES2Interface* and call a
getAGLInterface() or something like that.

[Zhenyao Mo, 2016-03-25 23:15:15]

https://codereview.chromium.org/1833273002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webgl/WebGLContextGroup.h (right):

https://codereview.chromium.org/1833273002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGLContextGroup.h:56:
WebGLRenderingContextBase* getAWebGLRenderingContextBase();
On 2016/03/25 23:13:52, Zhenyao Mo wrote:
> I think here you can return a gpu::gles2::GLES2Interface* and call a
> getAGLInterface() or something like that.

I mean here and all other places.  Exposing WebGLRenderingContextBase() is an
overkill.

[danakj, 2016-03-25 23:36:58]

Description was changed from

==========
Remove WebGraphicsContext3D::getGLES2Interface().

We no longer have WebGraphicsContext3D without having access to the
actual GLES2Interface anywhere, so we don't need the method. The last
holdout was getAWebGraphicsContext3D() in the WebGLObjects. This
was changed to get a WebGLRenderingContextBase from which it can
get a GLES2Interface, and we remove the unused WebGraphicsContext3D*
plumbing all over them.

R=kbr@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Remove WebGraphicsContext3D::getGLES2Interface().

We no longer have WebGraphicsContext3D without having access to the
actual GLES2Interface anywhere, so we don't need the method. The last
holdout was getAWebGraphicsContext3D() in the WebGLObjects. This
was changed to get a WebGLRenderingContextBase from which it can
get a GLES2Interface, and we remove the unused WebGraphicsContext3D*
plumbing all over them.

R=kbr@chromium.org
TBR=
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[danakj, 2016-03-25 23:37:07]

TBRing the code deletes in gpu/

[danakj, 2016-03-25 23:37:13]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-03-25 23:37:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org, dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/1833273002/#ps40001
(title: "getgles2: todo")

[commit-bot: I haz the power, 2016-03-25 23:37:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1833273002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1833273002/40001

[danakj, 2016-03-25 23:41:17]

https://codereview.chromium.org/1833273002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webgl/WebGLContextGroup.h (right):

https://codereview.chromium.org/1833273002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGLContextGroup.h:56:
WebGLRenderingContextBase* getAWebGLRenderingContextBase();
On 2016/03/25 23:15:15, Zhenyao Mo wrote:
> On 2016/03/25 23:13:52, Zhenyao Mo wrote:
> > I think here you can return a gpu::gles2::GLES2Interface* and call a
> > getAGLInterface() or something like that.
> 
> I mean here and all other places.  Exposing WebGLRenderingContextBase() is an
> overkill.

Had to rebase on my other CL anyways. Done.

[danakj, 2016-03-25 23:49:57]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-25 23:50:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1833273002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1833273002/80001

[piman, 2016-03-26 00:35:24]

piman@chromium.org changed reviewers:
+ piman@chromium.org

[piman, 2016-03-26 00:35:25]

lgtm

[commit-bot: I haz the power, 2016-03-26 01:12:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-26 01:12:35]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[danakj, 2016-03-28 20:18:28]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-28 20:19:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1833273002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1833273002/100001

[danakj, 2016-03-28 21:38:30]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2016-03-28 21:38:35]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-03-28 21:38:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org, dalecurtis@chromium.org, zmo@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1833273002/#ps100001
(title: "getgles2: rebase")

[commit-bot: I haz the power, 2016-03-28 21:38:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1833273002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1833273002/100001

[danakj, 2016-03-28 21:40:31]

Description was changed from

==========
Remove WebGraphicsContext3D::getGLES2Interface().

We no longer have WebGraphicsContext3D without having access to the
actual GLES2Interface anywhere, so we don't need the method. The last
holdout was getAWebGraphicsContext3D() in the WebGLObjects. This
was changed to get a WebGLRenderingContextBase from which it can
get a GLES2Interface, and we remove the unused WebGraphicsContext3D*
plumbing all over them.

R=kbr@chromium.org
TBR=
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Remove WebGraphicsContext3D::getGLES2Interface().

We no longer have WebGraphicsContext3D without having access to the
actual GLES2Interface anywhere, so we don't need the method. The last
holdout was getAWebGraphicsContext3D() in the WebGLObjects. This
was changed to get a WebGLRenderingContextBase from which it can
get a GLES2Interface, and we remove the unused WebGraphicsContext3D*
plumbing all over them.

R=kbr@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[danakj, 2016-03-28 21:40:39]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2016-03-28 21:40:48]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-03-28 21:41:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1833273002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1833273002/100001

[commit-bot: I haz the power, 2016-03-28 21:54:19]

Description was changed from

==========
Remove WebGraphicsContext3D::getGLES2Interface().

We no longer have WebGraphicsContext3D without having access to the
actual GLES2Interface anywhere, so we don't need the method. The last
holdout was getAWebGraphicsContext3D() in the WebGLObjects. This
was changed to get a WebGLRenderingContextBase from which it can
get a GLES2Interface, and we remove the unused WebGraphicsContext3D*
plumbing all over them.

R=kbr@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Remove WebGraphicsContext3D::getGLES2Interface().

We no longer have WebGraphicsContext3D without having access to the
actual GLES2Interface anywhere, so we don't need the method. The last
holdout was getAWebGraphicsContext3D() in the WebGLObjects. This
was changed to get a WebGLRenderingContextBase from which it can
get a GLES2Interface, and we remove the unused WebGraphicsContext3D*
plumbing all over them.

R=kbr@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-03-28 21:54:21]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-03-28 21:55:32]

Description was changed from

==========
Remove WebGraphicsContext3D::getGLES2Interface().

We no longer have WebGraphicsContext3D without having access to the
actual GLES2Interface anywhere, so we don't need the method. The last
holdout was getAWebGraphicsContext3D() in the WebGLObjects. This
was changed to get a WebGLRenderingContextBase from which it can
get a GLES2Interface, and we remove the unused WebGraphicsContext3D*
plumbing all over them.

R=kbr@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Remove WebGraphicsContext3D::getGLES2Interface().

We no longer have WebGraphicsContext3D without having access to the
actual GLES2Interface anywhere, so we don't need the method. The last
holdout was getAWebGraphicsContext3D() in the WebGLObjects. This
was changed to get a WebGLRenderingContextBase from which it can
get a GLES2Interface, and we remove the unused WebGraphicsContext3D*
plumbing all over them.

R=kbr@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/46070b02edbd8d5531a143612c53f1a77baded40
Cr-Commit-Position: refs/heads/master@{#383576}
==========

[commit-bot: I haz the power, 2016-03-28 21:55:34]

Patchset 6 (id:??) landed as
https://crrev.com/46070b02edbd8d5531a143612c53f1a77baded40
Cr-Commit-Position: refs/heads/master@{#383576}