Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 1832263002: Remove WGC3D typedefs and move WebGraphicsInfo to Platform. (Closed)

Created:
4 years, 9 months ago by danakj
Modified:
4 years, 8 months ago
CC:
chrishtr, ajuma+watch-canvas_chromium.org, bajones, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, dcheng, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jam, jbauman+watch_chromium.org, jbroman, jochen+watch_chromium.org, Justin Novosad, kalyank, Ken Russell (switch to Gerrit), kinuko+watch, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-test-runner_chromium.org, mlamouri+watch-content_chromium.org, pdr+graphicswatchlist_chromium.org, piman+watch_chromium.org, piman, rwlbuis, Stephen Chennney, sievers+watch_chromium.org, no sievers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WGC3D typedefs and move WebGraphicsInfo to Platform. This removes the WGC3Dfoo basic type aliases that are synonyms for GLfoo and changes users that still exist to the GL versions. WebGLId is converted to GLuint which is the real deal. We remove the WebGraphicsContext3D::WebGraphicsInfo struct, moving it to the Platform class which is where it is used (for creating context providers). R=chrishtr, kbr@chromium.org, piman, pfeldman TBR=pfeldman BUG=584497 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/d4100e5324db5db722c4c1de3f1edaed76d6b137 Cr-Commit-Position: refs/heads/master@{#383595}

Patch Set 1 #

Patch Set 2 : webgraphicsinfo: rebase #

Patch Set 3 : webgraphicsinfo: rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -124 lines) Patch
M components/test_runner/test_plugin.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/render_widget_fullscreen_pepper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/renderer_blink_platform_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/blink/webgraphicscontext3d_impl.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/blink/webgraphicscontext3d_impl.cc View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
M gpu/blink/webgraphicscontext3d_in_process_command_buffer_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h View 7 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp View 11 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTest.cpp View 1 2 16 chunks +19 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/SharedContextRateLimiter.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/SharedContextRateLimiter.cpp View 1 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/public/platform/Platform.h View 1 chunk +15 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebGraphicsContext3D.h View 1 2 3 chunks +1 line, -39 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 24 (13 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832263002/1
4 years, 9 months ago (2016-03-25 22:57:03 UTC) #3
danakj
kbr: everything piman: content pfeldman: TBR for test_runner chrishtr: public (PTAL at the struct move ...
4 years, 9 months ago (2016-03-25 22:57:33 UTC) #6
chrishtr
lgtm
4 years, 9 months ago (2016-03-25 23:00:06 UTC) #7
piman
lgtm
4 years, 9 months ago (2016-03-25 23:01:12 UTC) #8
Zhenyao Mo
lgtm
4 years, 9 months ago (2016-03-25 23:19:14 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832263002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832263002/40001
4 years, 9 months ago (2016-03-25 23:51:21 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/200864)
4 years, 9 months ago (2016-03-26 01:06:23 UTC) #15
Ken Russell (switch to Gerrit)
Thanks for continuing to do this cleanup. LGTM
4 years, 8 months ago (2016-03-28 18:39:53 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832263002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832263002/80001
4 years, 8 months ago (2016-03-28 22:04:36 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:80001)
4 years, 8 months ago (2016-03-28 23:06:23 UTC) #22
commit-bot: I haz the power
4 years, 8 months ago (2016-03-28 23:08:00 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d4100e5324db5db722c4c1de3f1edaed76d6b137
Cr-Commit-Position: refs/heads/master@{#383595}

Powered by Google App Engine
This is Rietveld 408576698