third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h - Issue 1833273002: Remove WebGraphicsContext3D::getGLES2Interface().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

Issue 1833273002: Remove WebGraphicsContext3D::getGLES2Interface(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: getgles2: rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h b/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

index ff3915f1c2081058f414b24bd31052f6c1a451ed..3907adb2466d53843daacef3021854eb72e290ad 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

+++ b/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

@@ -50,7 +50,7 @@ public:

virtual WebGLSharedObject* object() const = 0;

virtual bool isSharedObject(WebGLSharedObject*) const = 0;

virtual bool valid() const = 0;

- virtual void onDetached(WebGraphicsContext3D*, gpu::gles2::GLES2Interface*) = 0;

+ virtual void onDetached(gpu::gles2::GLES2Interface*) = 0;

virtual void attach(gpu::gles2::GLES2Interface*, GLenum target, GLenum attachment) = 0;

virtual void unattach(gpu::gles2::GLES2Interface*, GLenum target, GLenum attachment) = 0;

@@ -100,7 +100,7 @@ protected:

explicit WebGLFramebuffer(WebGLRenderingContextBase*);

bool hasObject() const override { return m_object != 0; }

- void deleteObjectImpl(WebGraphicsContext3D*, gpu::gles2::GLES2Interface*) override;

+ void deleteObjectImpl(gpu::gles2::GLES2Interface*) override;

private:

WebGLAttachment* getAttachment(GLenum attachment) const;