Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1815803003: Move simple methods [T-Z] from WebGraphicsContext3D to GLES2Interface. (Closed)

Created:
4 years, 9 months ago by danakj
Modified:
4 years, 9 months ago
CC:
ajuma+watch-canvas_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dcheng, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, jochen+watch_chromium.org, Justin Novosad, kinuko+watch, mlamouri+watch-test-runner_chromium.org, pdr+graphicswatchlist_chromium.org, piman+watch_chromium.org, piman, rwlbuis, Stephen Chennney, no sievers
Base URL:
https://chromium.googlesource.com/chromium/src.git@simples-fplus
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move simple methods [T-Z] from WebGraphicsContext3D to GLES2Interface. This removes methods from WebGraphicsContext3D that were simple macro- based pass-throughs to the underlying GLES2Interface, and changes callers in blink to use the GLES2Interface for them instead. This is ~the last of the OpenGLES 2.0 methods that are simple pass- throughs. R=bajones@chromium.org, kbr@chromium.org, piman@chromium.org TBR=pfeldman BUG=584497 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/943cc76639df0d20dda0c9891e08ec38fe19540f Cr-Commit-Position: refs/heads/master@{#382174}

Patch Set 1 #

Total comments: 1

Patch Set 2 : simples-tplus: iosurface #

Patch Set 3 : simples-tplus: fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -975 lines) Patch
M components/test_runner/test_plugin.cc View 9 chunks +18 lines, -26 lines 0 comments Download
M gpu/blink/webgraphicscontext3d_impl.h View 6 chunks +0 lines, -286 lines 0 comments Download
M gpu/blink/webgraphicscontext3d_impl.cc View 8 chunks +0 lines, -218 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/CHROMIUMValuebuffer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/CHROMIUMValuebuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/EXTDisjointTimerQuery.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/OESVertexArrayObject.cpp View 4 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp View 36 chunks +50 lines, -50 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLBuffer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLContextObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp View 8 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLObject.h View 3 chunks +9 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLObject.cpp View 1 2 4 chunks +10 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLProgram.h View 2 chunks +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLProgram.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLQuery.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLQuery.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderbuffer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderbuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 52 chunks +67 lines, -67 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLSampler.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLSampler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLShader.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLShader.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLSharedObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLSync.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLSync.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLTexture.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLTexture.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLTimerQueryEXT.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLTimerQueryEXT.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLTransformFeedback.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLTransformFeedback.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.cpp View 5 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp View 1 3 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp View 6 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTest.cpp View 10 chunks +72 lines, -73 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/test/MockWebGraphicsContext3D.h View 2 chunks +0 lines, -48 lines 0 comments Download
M third_party/WebKit/public/platform/WebGraphicsContext3D.h View 5 chunks +0 lines, -103 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 41 (19 generated)
danakj
bajones: modules/webgl/ piman: gpu/ platform/ public/ chrishtr: platform/ and public/ OWNERS pfeldman: TBR for test_runner/
4 years, 9 months ago (2016-03-18 22:22:21 UTC) #3
danakj
Oops, +bajones for modules :)
4 years, 9 months ago (2016-03-18 22:22:35 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815803003/1
4 years, 9 months ago (2016-03-18 22:23:26 UTC) #8
chrishtr
lgtm
4 years, 9 months ago (2016-03-18 22:40:46 UTC) #9
bajones
modules/ LGTM
4 years, 9 months ago (2016-03-18 22:59:37 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/191559)
4 years, 9 months ago (2016-03-19 00:18:33 UTC) #12
danakj
Aw I broke something.
4 years, 9 months ago (2016-03-19 00:25:57 UTC) #13
danakj
https://codereview.chromium.org/1815803003/diff/1/third_party/WebKit/Source/modules/webgl/WebGLObject.cpp File third_party/WebKit/Source/modules/webgl/WebGLObject.cpp (right): https://codereview.chromium.org/1815803003/diff/1/third_party/WebKit/Source/modules/webgl/WebGLObject.cpp#newcode53 third_party/WebKit/Source/modules/webgl/WebGLObject.cpp:53: context3d = getAWebGraphicsContext3D(); Oh this can get a context3d ...
4 years, 9 months ago (2016-03-19 00:31:50 UTC) #14
danakj
Fixed. piman@ PTAL at components, gpu and platform for me.
4 years, 9 months ago (2016-03-19 00:36:15 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815803003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815803003/40001
4 years, 9 months ago (2016-03-19 00:36:51 UTC) #20
Ken Russell (switch to Gerrit)
lgtm fwiw. Thanks for continuing this cleanup.
4 years, 9 months ago (2016-03-19 00:37:57 UTC) #21
danakj
OOh thanks! CQin'
4 years, 9 months ago (2016-03-19 00:38:26 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815803003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815803003/40001
4 years, 9 months ago (2016-03-19 00:39:28 UTC) #25
Ken Russell (switch to Gerrit)
On 2016/03/19 00:38:26, danakj wrote: > OOh thanks! CQin' Note: I'm not an OWNER in ...
4 years, 9 months ago (2016-03-19 00:53:15 UTC) #26
Ken Russell (switch to Gerrit)
On 2016/03/19 00:53:15, Ken Russell wrote: > On 2016/03/19 00:38:26, danakj wrote: > > OOh ...
4 years, 9 months ago (2016-03-19 00:53:43 UTC) #27
piman
lgtm
4 years, 9 months ago (2016-03-19 00:58:28 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
4 years, 9 months ago (2016-03-19 02:37:56 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815803003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815803003/40001
4 years, 9 months ago (2016-03-19 02:40:38 UTC) #32
Ken Russell (switch to Gerrit)
On 2016/03/19 02:37:56, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 9 months ago (2016-03-19 02:46:58 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815803003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815803003/40001
4 years, 9 months ago (2016-03-19 02:51:30 UTC) #37
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-19 02:56:47 UTC) #39
commit-bot: I haz the power
4 years, 9 months ago (2016-03-19 02:58:16 UTC) #41
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/943cc76639df0d20dda0c9891e08ec38fe19540f
Cr-Commit-Position: refs/heads/master@{#382174}

Powered by Google App Engine
This is Rietveld 408576698