Remove methods from WebGraphicsContext3D that wrap type casts.

Remove methods from WebGraphicsContext3D that wrap type casts.

There were a set of methods that just pass through to the GLES2Interface
but do some type casting along the way. Move those casts to the caller
or use GL types instead of WGC3D types directly, and call GLES2Interface
instead of WebGraphicsContext3D for the methods.

R=bajones@chromium.org, pfeldman@chromium.org, piman@chromium.org
TBR=pfeldman
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/ed585b378ae0a8e410ae5b508821869fe4435d30
Cr-Commit-Position: refs/heads/master@{#382470}

[danakj, 2016-03-18 23:22:22]

Description was changed from

==========
Remove methods from WebGraphicsContext3D that wrap type casts.

There were a set of methods that just pass through to the GLES2Interface
but do some type casting along the way. Move those casts to the caller
or use GL types instead of WGC3D types directly, and call GLES2Interface
instead of WebGraphicsContext3D for the methods.

R=bajones@chromium.org, pfeldman@chromium.org, piman@chromium.org
BUG=584497
==========

to

==========
Remove methods from WebGraphicsContext3D that wrap type casts.

There were a set of methods that just pass through to the GLES2Interface
but do some type casting along the way. Move those casts to the caller
or use GL types instead of WGC3D types directly, and call GLES2Interface
instead of WebGraphicsContext3D for the methods.

R=bajones@chromium.org, pfeldman@chromium.org, piman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[danakj, 2016-03-18 23:22:53]

bajones: modules/
piman: test_runner/ gpu/ platform/ public/
chrishtr: platform/ public/ OWNERS
pfeldman: TBR for test_runner

[chrishtr, 2016-03-18 23:23:51]

chrishtr@chromium.org changed reviewers:
+ chrishtr@chromium.org

[chrishtr, 2016-03-18 23:23:51]

lgtm

[danakj, 2016-03-18 23:24:44]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[danakj, 2016-03-18 23:24:55]

Description was changed from

==========
Remove methods from WebGraphicsContext3D that wrap type casts.

There were a set of methods that just pass through to the GLES2Interface
but do some type casting along the way. Move those casts to the caller
or use GL types instead of WGC3D types directly, and call GLES2Interface
instead of WebGraphicsContext3D for the methods.

R=bajones@chromium.org, pfeldman@chromium.org, piman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Remove methods from WebGraphicsContext3D that wrap type casts.

There were a set of methods that just pass through to the GLES2Interface
but do some type casting along the way. Move those casts to the caller
or use GL types instead of WGC3D types directly, and call GLES2Interface
instead of WebGraphicsContext3D for the methods.

R=bajones@chromium.org, pfeldman@chromium.org, piman@chromium.org
TBR=pfeldman
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-03-18 23:25:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812243003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812243003/1

[bajones, 2016-03-18 23:34:10]

modules/ LGTM

[danakj, 2016-03-19 01:23:15]

danakj@chromium.org changed reviewers:
+ kbr@chromium.org

[danakj, 2016-03-19 01:23:15]

+kbr for gpu/blink/ and components/

[danakj, 2016-03-19 01:23:30]

danakj@chromium.org changed reviewers:
+ kbr@chromium.org

[danakj, 2016-03-19 01:23:41]

On 2016/03/19 01:23:15, danakj wrote:
> +kbr for gpu/blink/ and components/

Typing is hard. ^ for real.

[piman, 2016-03-19 01:28:35]

lgtm

https://codereview.chromium.org/1812243003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
(right):

https://codereview.chromium.org/1812243003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp:38:
return object ? reinterpret_cast<GLsync>(object->object()) : nullptr;
nit: no need for the reinterpret_cast

https://codereview.chromium.org/1812243003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGLSync.h (right):

https://codereview.chromium.org/1812243003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGLSync.h:34: GLsync m_object;
nit: is WGC3Dsync still used anywhere? If not, remove from WebGraphicsContext3D

[Ken Russell (switch to Gerrit), 2016-03-19 02:20:44]

lgtm

[danakj, 2016-03-21 22:02:38]

https://codereview.chromium.org/1812243003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
(right):

https://codereview.chromium.org/1812243003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp:38:
return object ? reinterpret_cast<GLsync>(object->object()) : nullptr;
On 2016/03/19 01:28:35, piman wrote:
> nit: no need for the reinterpret_cast

Done.

https://codereview.chromium.org/1812243003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGLSync.h (right):

https://codereview.chromium.org/1812243003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGLSync.h:34: GLsync m_object;
On 2016/03/19 01:28:35, piman wrote:
> nit: is WGC3Dsync still used anywhere? If not, remove from
WebGraphicsContext3D

Done.

[danakj, 2016-03-21 22:02:52]

Description was changed from

==========
Remove methods from WebGraphicsContext3D that wrap type casts.

There were a set of methods that just pass through to the GLES2Interface
but do some type casting along the way. Move those casts to the caller
or use GL types instead of WGC3D types directly, and call GLES2Interface
instead of WebGraphicsContext3D for the methods.

R=bajones@chromium.org, pfeldman@chromium.org, piman@chromium.org
TBR=pfeldman
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Remove methods from WebGraphicsContext3D that wrap type casts.

There were a set of methods that just pass through to the GLES2Interface
but do some type casting along the way. Move those casts to the caller
or use GL types instead of WGC3D types directly, and call GLES2Interface
instead of WebGraphicsContext3D for the methods.

R=bajones@chromium.org, pfeldman@chromium.org, piman@chromium.org
TBR=pfeldman
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[danakj, 2016-03-21 22:03:24]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-03-21 22:03:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org, bajones@chromium.org, kbr@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1812243003/#ps40001
(title: "complex-casts: rebase-review")

[commit-bot: I haz the power, 2016-03-21 22:03:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812243003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812243003/40001

[danakj, 2016-03-21 22:47:25]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-03-21 22:47:26]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
chrishtr@chromium.org, bajones@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1812243003/#ps60001
(title: "complex-casts: rebase")

[commit-bot: I haz the power, 2016-03-21 22:47:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812243003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812243003/60001

[commit-bot: I haz the power, 2016-03-22 01:17:27]

Description was changed from

==========
Remove methods from WebGraphicsContext3D that wrap type casts.

There were a set of methods that just pass through to the GLES2Interface
but do some type casting along the way. Move those casts to the caller
or use GL types instead of WGC3D types directly, and call GLES2Interface
instead of WebGraphicsContext3D for the methods.

R=bajones@chromium.org, pfeldman@chromium.org, piman@chromium.org
TBR=pfeldman
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove methods from WebGraphicsContext3D that wrap type casts.

There were a set of methods that just pass through to the GLES2Interface
but do some type casting along the way. Move those casts to the caller
or use GL types instead of WGC3D types directly, and call GLES2Interface
instead of WebGraphicsContext3D for the methods.

R=bajones@chromium.org, pfeldman@chromium.org, piman@chromium.org
TBR=pfeldman
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-03-22 01:17:29]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-22 01:18:54]

Description was changed from

==========
Remove methods from WebGraphicsContext3D that wrap type casts.

There were a set of methods that just pass through to the GLES2Interface
but do some type casting along the way. Move those casts to the caller
or use GL types instead of WGC3D types directly, and call GLES2Interface
instead of WebGraphicsContext3D for the methods.

R=bajones@chromium.org, pfeldman@chromium.org, piman@chromium.org
TBR=pfeldman
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove methods from WebGraphicsContext3D that wrap type casts.

There were a set of methods that just pass through to the GLES2Interface
but do some type casting along the way. Move those casts to the caller
or use GL types instead of WGC3D types directly, and call GLES2Interface
instead of WebGraphicsContext3D for the methods.

R=bajones@chromium.org, pfeldman@chromium.org, piman@chromium.org
TBR=pfeldman
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/ed585b378ae0a8e410ae5b508821869fe4435d30
Cr-Commit-Position: refs/heads/master@{#382470}
==========

[commit-bot: I haz the power, 2016-03-22 01:18:56]

Patchset 4 (id:??) landed as
https://crrev.com/ed585b378ae0a8e410ae5b508821869fe4435d30
Cr-Commit-Position: refs/heads/master@{#382470}