Remove genSyncTokenCHROMIUM from WebGraphicsContext3D.

Remove genSyncTokenCHROMIUM from WebGraphicsContext3D.

Use the method on GLES2Interface instead. The difference was that
WebGraphicsContext3D returned a bool, which was always true.

R=dyen@chromium.org, junov@chromium.org, pfeldman@chromium.org, piman@chromium.org
TBR=pfeldman
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/950fab13a9308d91fee7be55503b077609f07e00
Cr-Commit-Position: refs/heads/master@{#382413}

[danakj, 2016-03-18 22:38:06]

Description was changed from

==========
Remove genSyncTokenCHROMIUM from WebGraphicsContext3D.

Use the method on GLES2Interface instead. The difference was that
WebGraphicsContext3D returned a bool, which was always true.

R=dyen@chromium.org, junov@chromium.org, pfeldman@chromium.org,
piman@chromium.org
BUG=584497
==========

to

==========
Remove genSyncTokenCHROMIUM from WebGraphicsContext3D.

Use the method on GLES2Interface instead. The difference was that
WebGraphicsContext3D returned a bool, which was always true.

R=dyen@chromium.org, junov@chromium.org, pfeldman@chromium.org,
piman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[danakj, 2016-03-18 22:38:51]

I can't tell if i can get rid of the mailbox.validSyncToken field entirely.

WebExternalTextureLayerImpl::DidReleaseMailbox sets it to false potentially:

  available_mailbox.validSyncToken = sync_token.HasData();

[danakj, 2016-03-18 23:24:41]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-18 23:25:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812363002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812363002/1

[piman, 2016-03-18 23:44:49]

LGTM.

If you can convince people that using gpu::SyncToken is ok, then you can use it
directly in blink code, and use HasData(). Otherwise I think you need to keep a
way to tell apart when you have no sync token yet vs when you have one.

[danakj, 2016-03-18 23:48:20]

On 2016/03/18 23:44:49, piman wrote:
> LGTM.
> 
> If you can convince people that using gpu::SyncToken is ok, then you can use
it
> directly in blink code, and use HasData(). Otherwise I think you need to keep
a
> way to tell apart when you have no sync token yet vs when you have one.

Oh ok!

[commit-bot: I haz the power, 2016-03-19 00:28:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-19 00:28:36]

Dry run: Try jobs failed on following builders:
  win_optional_gpu_tests_rel on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)

[danakj, 2016-03-19 01:27:38]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[danakj, 2016-03-19 01:27:52]

Description was changed from

==========
Remove genSyncTokenCHROMIUM from WebGraphicsContext3D.

Use the method on GLES2Interface instead. The difference was that
WebGraphicsContext3D returned a bool, which was always true.

R=dyen@chromium.org, junov@chromium.org, pfeldman@chromium.org,
piman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Remove genSyncTokenCHROMIUM from WebGraphicsContext3D.

Use the method on GLES2Interface instead. The difference was that
WebGraphicsContext3D returned a bool, which was always true.

R=dyen@chromium.org, junov@chromium.org, pfeldman@chromium.org,
piman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-03-19 01:27:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812363002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812363002/20001

[danakj, 2016-03-19 02:52:20]

Description was changed from

==========
Remove genSyncTokenCHROMIUM from WebGraphicsContext3D.

Use the method on GLES2Interface instead. The difference was that
WebGraphicsContext3D returned a bool, which was always true.

R=dyen@chromium.org, junov@chromium.org, pfeldman@chromium.org,
piman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove genSyncTokenCHROMIUM from WebGraphicsContext3D.

Use the method on GLES2Interface instead. The difference was that
WebGraphicsContext3D returned a bool, which was always true.

R=dyen@chromium.org, junov@chromium.org, pfeldman@chromium.org,
piman@chromium.org
TBR=pfeldman,chrishtr
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[danakj, 2016-03-19 02:52:28]

Description was changed from

==========
Remove genSyncTokenCHROMIUM from WebGraphicsContext3D.

Use the method on GLES2Interface instead. The difference was that
WebGraphicsContext3D returned a bool, which was always true.

R=dyen@chromium.org, junov@chromium.org, pfeldman@chromium.org,
piman@chromium.org
TBR=pfeldman,chrishtr
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove genSyncTokenCHROMIUM from WebGraphicsContext3D.

Use the method on GLES2Interface instead. The difference was that
WebGraphicsContext3D returned a bool, which was always true.

R=dyen@chromium.org, junov@chromium.org, pfeldman@chromium.org,
piman@chromium.org
TBR=pfeldman
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-03-19 02:52:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-19 02:52:44]

Dry run: This issue passed the CQ dry run.

[danakj, 2016-03-19 02:52:45]

danakj@chromium.org changed reviewers:
+ chrishtr@chromium.org

[danakj, 2016-03-19 02:52:46]

+chrishtr for platform/ and public/ owners

[danakj, 2016-03-19 02:52:56]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-19 02:53:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812363002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812363002/20001

[commit-bot: I haz the power, 2016-03-19 02:57:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-19 02:57:56]

Dry run: This issue passed the CQ dry run.

[chrishtr, 2016-03-21 15:05:20]

lgtm

[David Yen, 2016-03-21 18:35:50]

lgtm

[danakj, 2016-03-21 20:06:26]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-03-21 20:06:26]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1812363002/#ps20001
(title: "gensynctoken: rebase")

[commit-bot: I haz the power, 2016-03-21 20:06:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812363002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812363002/20001

[commit-bot: I haz the power, 2016-03-21 22:10:25]

Description was changed from

==========
Remove genSyncTokenCHROMIUM from WebGraphicsContext3D.

Use the method on GLES2Interface instead. The difference was that
WebGraphicsContext3D returned a bool, which was always true.

R=dyen@chromium.org, junov@chromium.org, pfeldman@chromium.org,
piman@chromium.org
TBR=pfeldman
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove genSyncTokenCHROMIUM from WebGraphicsContext3D.

Use the method on GLES2Interface instead. The difference was that
WebGraphicsContext3D returned a bool, which was always true.

R=dyen@chromium.org, junov@chromium.org, pfeldman@chromium.org,
piman@chromium.org
TBR=pfeldman
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-03-21 22:10:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-21 22:12:25]

Description was changed from

==========
Remove genSyncTokenCHROMIUM from WebGraphicsContext3D.

Use the method on GLES2Interface instead. The difference was that
WebGraphicsContext3D returned a bool, which was always true.

R=dyen@chromium.org, junov@chromium.org, pfeldman@chromium.org,
piman@chromium.org
TBR=pfeldman
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove genSyncTokenCHROMIUM from WebGraphicsContext3D.

Use the method on GLES2Interface instead. The difference was that
WebGraphicsContext3D returned a bool, which was always true.

R=dyen@chromium.org, junov@chromium.org, pfeldman@chromium.org,
piman@chromium.org
TBR=pfeldman
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/950fab13a9308d91fee7be55503b077609f07e00
Cr-Commit-Position: refs/heads/master@{#382413}
==========

[commit-bot: I haz the power, 2016-03-21 22:12:27]

Patchset 2 (id:??) landed as
https://crrev.com/950fab13a9308d91fee7be55503b077609f07e00
Cr-Commit-Position: refs/heads/master@{#382413}