Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1808403002: Move simple methods [F-S] from WebGraphicsContext3D to GLES2Interface. (Closed)

Created:
4 years, 9 months ago by danakj
Modified:
4 years, 9 months ago
CC:
ajuma+watch-canvas_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dcheng, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, jochen+watch_chromium.org, Justin Novosad, kinuko+watch, mlamouri+watch-test-runner_chromium.org, pdr+graphicswatchlist_chromium.org, piman+watch_chromium.org, piman, rwlbuis, Stephen Chennney, no sievers, Zhenyao Mo
Base URL:
https://chromium.googlesource.com/chromium/src.git@bindFoo
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move simple methods [F-S] from WebGraphicsContext3D to GLES2Interface. This removes methods from WebGraphicsContext3D that were simple macro- based pass-throughs to the underlying GLES2Interface, and changes callers in blink to use the GLES2Interface for them instead. R=junov@chromium.org, kbr@chromium.org, piman@chromium.org TBR=pfeldman BUG=584497 Committed: https://crrev.com/efbc81bcc0145b3df17eaa9bd24c833fad958e83 Cr-Commit-Position: refs/heads/master@{#382135}

Patch Set 1 #

Patch Set 2 : simples-fplus: android #

Patch Set 3 : simples-fplus: mac #

Patch Set 4 : simples-fplus: rebase #

Patch Set 5 : simples-fplus: tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+276 lines, -741 lines) Patch
M components/test_runner/test_plugin.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M gpu/blink/webgraphicscontext3d_impl.h View 4 chunks +0 lines, -181 lines 0 comments Download
M gpu/blink/webgraphicscontext3d_impl.cc View 9 chunks +0 lines, -169 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/EXTDisjointTimerQuery.cpp View 7 chunks +8 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp View 22 chunks +38 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLProgram.h View 2 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLProgram.cpp View 3 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLQuery.h View 2 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLQuery.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 58 chunks +86 lines, -85 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLTimerQueryEXT.h View 2 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLTimerQueryEXT.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp View 1 2 3 4 4 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp View 1 2 3 4 11 chunks +22 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTest.cpp View 1 2 3 4 9 chunks +55 lines, -47 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/SharedContextRateLimiter.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/test/MockWebGraphicsContext3D.h View 2 chunks +0 lines, -69 lines 0 comments Download
M third_party/WebKit/public/platform/WebGraphicsContext3D.h View 3 chunks +0 lines, -77 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 40 (20 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808403002/1
4 years, 9 months ago (2016-03-18 00:04:40 UTC) #3
danakj
4 years, 9 months ago (2016-03-18 00:05:09 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/197044)
4 years, 9 months ago (2016-03-18 00:16:01 UTC) #7
piman
lgtm
4 years, 9 months ago (2016-03-18 00:16:17 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808403002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808403002/40001
4 years, 9 months ago (2016-03-18 00:29:38 UTC) #10
danakj
+chrishtr for public/ owners
4 years, 9 months ago (2016-03-18 20:25:34 UTC) #11
danakj
+chrishtr for public/
4 years, 9 months ago (2016-03-18 20:26:15 UTC) #13
chrishtr
lgtm
4 years, 9 months ago (2016-03-18 20:43:46 UTC) #14
danakj
+bajones for modules/
4 years, 9 months ago (2016-03-18 20:52:49 UTC) #16
bajones
On 2016/03/18 20:52:49, danakj wrote: > +bajones for modules/ modules/ LGTM. Great cleanup, thanks! Can't ...
4 years, 9 months ago (2016-03-18 20:56:32 UTC) #17
danakj
TBR=pfeldman for test_runner
4 years, 9 months ago (2016-03-18 20:59:51 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808403002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808403002/80001
4 years, 9 months ago (2016-03-18 21:00:33 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808403002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808403002/80001
4 years, 9 months ago (2016-03-18 22:56:23 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
4 years, 9 months ago (2016-03-18 23:03:04 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808403002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808403002/80001
4 years, 9 months ago (2016-03-18 23:05:51 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808403002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808403002/80001
4 years, 9 months ago (2016-03-18 23:25:24 UTC) #34
Ken Russell (switch to Gerrit)
On 2016/03/18 23:03:04, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 9 months ago (2016-03-19 00:18:25 UTC) #35
danakj
On 2016/03/19 00:18:25, Ken Russell wrote: > On 2016/03/18 23:03:04, commit-bot: I haz the power ...
4 years, 9 months ago (2016-03-19 00:25:50 UTC) #36
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 9 months ago (2016-03-19 00:27:29 UTC) #38
commit-bot: I haz the power
4 years, 9 months ago (2016-03-19 00:28:26 UTC) #40
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/efbc81bcc0145b3df17eaa9bd24c833fad958e83
Cr-Commit-Position: refs/heads/master@{#382135}

Powered by Google App Engine
This is Rietveld 408576698