Remove getError() and synthesizeGLError() from WebGraphicsContext3D.

Remove getError() and synthesizeGLError() from WebGraphicsContext3D.

This moves synthetic gl errors entirely into WebGLRenderingContextBase,
as all callers that need to synthesize errors have access to or are
inside that class.

We deleted some dead WebKit code in WebGLProgram to make the above true.

Callers to synthesizeGLError() now call the same public method of
WebGLRenderingContextBase instead, which allows them to provide
additional debug strings.

One caller to getError() was switched to GLES2Interface::GetError
in DrawingBuffer as that appears separate from the needs for synthetic
errors entirely.

R=bajones@chromium.org, chrishtr@chromium.org, kbr@chromium.org, pfeldman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/f6cc81c7e7f6ae0cc7259a276375fa0ccceec26c
Cr-Commit-Position: refs/heads/master@{#382446}

[danakj, 2016-03-19 02:49:23]

Description was changed from

==========
Remove getError() and synthesizeGLError() from WebGraphicsContext3D.

This moves synthetic gl errors entirely into WebGLRenderingContextBase,
as all callers that need to synthesize errors have access to or are
inside that class.

We deleted some dead WebKit code in WebGLProgram to make the above true.

Callers to synthesizeGLError() now call the same public method of
WebGLRenderingContextBase instead, which allows them to provide
additional debug strings.

One caller to getError() was switched to GLES2Interface::GetError
in DrawingBuffer as that appears separate from the needs for synthetic
errors entirely.

R=bajones@chromium.org, chrishtr@chromium.org, kbr@chromium.org,
pfeldman@chromium.org
TBR=pfeldman
BUG=584497
==========

to

==========
Remove getError() and synthesizeGLError() from WebGraphicsContext3D.

This moves synthetic gl errors entirely into WebGLRenderingContextBase,
as all callers that need to synthesize errors have access to or are
inside that class.

We deleted some dead WebKit code in WebGLProgram to make the above true.

Callers to synthesizeGLError() now call the same public method of
WebGLRenderingContextBase instead, which allows them to provide
additional debug strings.

One caller to getError() was switched to GLES2Interface::GetError
in DrawingBuffer as that appears separate from the needs for synthetic
errors entirely.

R=bajones@chromium.org, chrishtr@chromium.org, kbr@chromium.org,
pfeldman@chromium.org
TBR=pfeldman
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[danakj, 2016-03-19 02:51:37]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-19 02:51:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1824433002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1824433002/1

[commit-bot: I haz the power, 2016-03-19 03:46:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-19 03:46:08]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ken Russell (switch to Gerrit), 2016-03-19 04:36:04]

Awesome. LGTM

https://codereview.chromium.org/1824433002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGLProgram.cpp (right):

https://codereview.chromium.org/1824433002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGLProgram.cpp:160: // TODO(danakj):
Make this getAWebGLRenderingContextBase.
WebGLProgram::linkStatus() could be changed to take a WebGLRenderingContextBase*
and the only caller changed to pass itself. linkStatus could then pass the
WebGLRenderingContextBase* down to here, addressing the TODO.

https://codereview.chromium.org/1824433002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGLProgram.h (right):

https://codereview.chromium.org/1824433002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGLProgram.h:71: void
cacheActiveAttribLocations(WebGraphicsContext3D*, gpu::gles2::GLES2Interface*);
Should be deleted from header.

https://codereview.chromium.org/1824433002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
(right):

https://codereview.chromium.org/1824433002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:2424: if
(m_syntheticErrors.isEmpty()) {
Need "!".

[chrishtr, 2016-03-21 15:07:19]

lgtm

[danakj, 2016-03-21 22:45:09]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-03-21 22:45:10]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/1824433002/#ps20001
(title: "errors: review")

[danakj, 2016-03-21 22:45:14]

https://codereview.chromium.org/1824433002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGLProgram.cpp (right):

https://codereview.chromium.org/1824433002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGLProgram.cpp:160: // TODO(danakj):
Make this getAWebGLRenderingContextBase.
On 2016/03/19 04:36:04, Ken Russell wrote:
> WebGLProgram::linkStatus() could be changed to take a
WebGLRenderingContextBase*
> and the only caller changed to pass itself. linkStatus could then pass the
> WebGLRenderingContextBase* down to here, addressing the TODO.

Done.

https://codereview.chromium.org/1824433002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGLProgram.h (right):

https://codereview.chromium.org/1824433002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGLProgram.h:71: void
cacheActiveAttribLocations(WebGraphicsContext3D*, gpu::gles2::GLES2Interface*);
On 2016/03/19 04:36:04, Ken Russell wrote:
> Should be deleted from header.

Done.

https://codereview.chromium.org/1824433002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
(right):

https://codereview.chromium.org/1824433002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:2424: if
(m_syntheticErrors.isEmpty()) {
On 2016/03/19 04:36:04, Ken Russell wrote:
> Need "!".

Oops, thanks :)

[commit-bot: I haz the power, 2016-03-21 22:45:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1824433002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1824433002/20001

[commit-bot: I haz the power, 2016-03-21 22:47:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-21 22:47:27]

Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[danakj, 2016-03-21 22:50:55]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-03-21 22:50:55]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/1824433002/#ps40001
(title: "errors: rebase")

[commit-bot: I haz the power, 2016-03-21 22:51:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1824433002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1824433002/40001

[danakj, 2016-03-21 23:12:19]

Description was changed from

==========
Remove getError() and synthesizeGLError() from WebGraphicsContext3D.

This moves synthetic gl errors entirely into WebGLRenderingContextBase,
as all callers that need to synthesize errors have access to or are
inside that class.

We deleted some dead WebKit code in WebGLProgram to make the above true.

Callers to synthesizeGLError() now call the same public method of
WebGLRenderingContextBase instead, which allows them to provide
additional debug strings.

One caller to getError() was switched to GLES2Interface::GetError
in DrawingBuffer as that appears separate from the needs for synthetic
errors entirely.

R=bajones@chromium.org, chrishtr@chromium.org, kbr@chromium.org,
pfeldman@chromium.org
TBR=pfeldman
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Remove getError() and synthesizeGLError() from WebGraphicsContext3D.

This moves synthetic gl errors entirely into WebGLRenderingContextBase,
as all callers that need to synthesize errors have access to or are
inside that class.

We deleted some dead WebKit code in WebGLProgram to make the above true.

Callers to synthesizeGLError() now call the same public method of
WebGLRenderingContextBase instead, which allows them to provide
additional debug strings.

One caller to getError() was switched to GLES2Interface::GetError
in DrawingBuffer as that appears separate from the needs for synthetic
errors entirely.

R=bajones@chromium.org, chrishtr@chromium.org, kbr@chromium.org,
pfeldman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[danakj, 2016-03-21 23:12:32]

Description was changed from

==========
Remove getError() and synthesizeGLError() from WebGraphicsContext3D.

This moves synthetic gl errors entirely into WebGLRenderingContextBase,
as all callers that need to synthesize errors have access to or are
inside that class.

We deleted some dead WebKit code in WebGLProgram to make the above true.

Callers to synthesizeGLError() now call the same public method of
WebGLRenderingContextBase instead, which allows them to provide
additional debug strings.

One caller to getError() was switched to GLES2Interface::GetError
in DrawingBuffer as that appears separate from the needs for synthetic
errors entirely.

R=bajones@chromium.org, chrishtr@chromium.org, kbr@chromium.org,
pfeldman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Remove getError() and synthesizeGLError() from WebGraphicsContext3D.

This moves synthetic gl errors entirely into WebGLRenderingContextBase,
as all callers that need to synthesize errors have access to or are
inside that class.

We deleted some dead WebKit code in WebGLProgram to make the above true.

Callers to synthesizeGLError() now call the same public method of
WebGLRenderingContextBase instead, which allows them to provide
additional debug strings.

One caller to getError() was switched to GLES2Interface::GetError
in DrawingBuffer as that appears separate from the needs for synthetic
errors entirely.

R=bajones@chromium.org, chrishtr@chromium.org, kbr@chromium.org,
pfeldman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[danakj, 2016-03-21 23:12:38]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2016-03-21 23:12:43]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-03-21 23:13:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1824433002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1824433002/40001

[Ken Russell (switch to Gerrit), 2016-03-21 23:23:49]

Still awesome. Still LGTM.

[commit-bot: I haz the power, 2016-03-22 00:06:53]

Description was changed from

==========
Remove getError() and synthesizeGLError() from WebGraphicsContext3D.

This moves synthetic gl errors entirely into WebGLRenderingContextBase,
as all callers that need to synthesize errors have access to or are
inside that class.

We deleted some dead WebKit code in WebGLProgram to make the above true.

Callers to synthesizeGLError() now call the same public method of
WebGLRenderingContextBase instead, which allows them to provide
additional debug strings.

One caller to getError() was switched to GLES2Interface::GetError
in DrawingBuffer as that appears separate from the needs for synthetic
errors entirely.

R=bajones@chromium.org, chrishtr@chromium.org, kbr@chromium.org,
pfeldman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove getError() and synthesizeGLError() from WebGraphicsContext3D.

This moves synthetic gl errors entirely into WebGLRenderingContextBase,
as all callers that need to synthesize errors have access to or are
inside that class.

We deleted some dead WebKit code in WebGLProgram to make the above true.

Callers to synthesizeGLError() now call the same public method of
WebGLRenderingContextBase instead, which allows them to provide
additional debug strings.

One caller to getError() was switched to GLES2Interface::GetError
in DrawingBuffer as that appears separate from the needs for synthetic
errors entirely.

R=bajones@chromium.org, chrishtr@chromium.org, kbr@chromium.org,
pfeldman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-03-22 00:06:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-22 00:09:27]

Description was changed from

==========
Remove getError() and synthesizeGLError() from WebGraphicsContext3D.

This moves synthetic gl errors entirely into WebGLRenderingContextBase,
as all callers that need to synthesize errors have access to or are
inside that class.

We deleted some dead WebKit code in WebGLProgram to make the above true.

Callers to synthesizeGLError() now call the same public method of
WebGLRenderingContextBase instead, which allows them to provide
additional debug strings.

One caller to getError() was switched to GLES2Interface::GetError
in DrawingBuffer as that appears separate from the needs for synthetic
errors entirely.

R=bajones@chromium.org, chrishtr@chromium.org, kbr@chromium.org,
pfeldman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove getError() and synthesizeGLError() from WebGraphicsContext3D.

This moves synthetic gl errors entirely into WebGLRenderingContextBase,
as all callers that need to synthesize errors have access to or are
inside that class.

We deleted some dead WebKit code in WebGLProgram to make the above true.

Callers to synthesizeGLError() now call the same public method of
WebGLRenderingContextBase instead, which allows them to provide
additional debug strings.

One caller to getError() was switched to GLES2Interface::GetError
in DrawingBuffer as that appears separate from the needs for synthetic
errors entirely.

R=bajones@chromium.org, chrishtr@chromium.org, kbr@chromium.org,
pfeldman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/f6cc81c7e7f6ae0cc7259a276375fa0ccceec26c
Cr-Commit-Position: refs/heads/master@{#382446}
==========

[commit-bot: I haz the power, 2016-03-22 00:09:29]

Patchset 3 (id:??) landed as
https://crrev.com/f6cc81c7e7f6ae0cc7259a276375fa0ccceec26c
Cr-Commit-Position: refs/heads/master@{#382446}