Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1759653004: enforce 16byte alignment in shader contexts (Closed)

Created:
4 years, 9 months ago by reed1
Modified:
4 years, 9 months ago
Reviewers:
herb_g, mtklein, f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -79 lines) Patch
M experimental/SkPerlinNoiseShader2/SkPerlinNoiseShader2.h View 2 chunks +2 lines, -4 lines 0 comments Download
M experimental/SkPerlinNoiseShader2/SkPerlinNoiseShader2.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M include/core/SkShader.h View 2 chunks +7 lines, -4 lines 0 comments Download
M include/effects/SkPerlinNoiseShader.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/core/SkBitmapProcShader.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBitmapProcShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBlitter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkColorFilterShader.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/core/SkColorFilterShader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkColorShader.h View 2 chunks +3 lines, -4 lines 0 comments Download
M src/core/SkComposeShader.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/core/SkComposeShader.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/core/SkDraw.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkEmptyShader.h View 1 chunk +6 lines, -6 lines 0 comments Download
M src/core/SkLightingShader.cpp View 4 chunks +5 lines, -6 lines 0 comments Download
M src/core/SkLocalMatrixShader.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkPictureShader.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/core/SkPictureShader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkShader.cpp View 2 chunks +15 lines, -1 line 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/image/SkImageShader.h View 2 chunks +1 line, -1 line 0 comments Download
M src/image/SkImageShader.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
reed1
can't land the new bitmap shader until something like this guy lands
4 years, 9 months ago (2016-03-03 19:43:46 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1759653004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1759653004/1
4 years, 9 months ago (2016-03-03 19:43:57 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-03 20:01:21 UTC) #7
herb_g
lgtm
4 years, 9 months ago (2016-03-03 21:19:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1759653004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1759653004/1
4 years, 9 months ago (2016-03-03 21:24:25 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/d812fb458807245daa812adb7af0733cf5b54d96
4 years, 9 months ago (2016-03-03 21:25:29 UTC) #12
hal.canary
4 years, 9 months ago (2016-03-03 22:23:32 UTC) #13
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1759323002/ by halcanary@google.com.

The reason for reverting is: 
Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86-Debug failed dm:

	....
    FYI: loaded 23439 distinct uninteresting hashes from 23439 lines
    Skipping config gpu: Don't understand 'gpu'.
    Skipping config msaa16: Don't understand 'msaa16'.
    168400 srcs * 7 sinks + 481 tests == 1179281 tasks
    0ns elapsed, 5 active, 1179276 queued, 55MB RAM, 55MB peak
        565 gm  xfermodes2
        565 gm  xfermodes
        565 gm  xfermodeimagefilter
        565 gm  xfermodes3
        565 gm  verylarge_picture_image
    c:\0\build\slave\workdir\build\skia\src\core\skshader.cpp:108: 
        fatal error: ""(0 == ((size) & 15))""
    step returned non-zero exit code: 3
    @@@STEP_FAILURE@@@
.

Powered by Google App Engine
This is Rietveld 408576698