- Remove Isolate::Flags structure and store flags directly in isolate.

- Remove Isolate::Flags structure and store flags directly in isolate.
- Make enable_asserts, enable_type_checks, error_on_bad_override and
  error_on_bad_type release mode flags only.

BUG=
R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/8d18298fed7403c48196acddc480350a6de6eeee

[Ivan Posva, 2016-02-26 01:07:41]

iposva@google.com changed reviewers:
+ fschneider@google.com

[Florian Schneider, 2016-02-26 01:52:09]

lgtm

https://codereview.chromium.org/1737693003/diff/1/runtime/vm/flag_list.h
File runtime/vm/flag_list.h (right):

https://codereview.chromium.org/1737693003/diff/1/runtime/vm/flag_list.h#newc...
runtime/vm/flag_list.h:58: R(enable_type_checks, false, bool, false,            
                         \
Move up to keep alphabetical sorting.

https://codereview.chromium.org/1737693003/diff/1/runtime/vm/isolate.h
File runtime/vm/isolate.h (right):

https://codereview.chromium.org/1737693003/diff/1/runtime/vm/isolate.h#newcod...
runtime/vm/isolate.h:646: bool asserts() const { return false; }
Would return FLAG_enable_asserts work here, and for the other 3 cases? (since
they should be constant in PRODUCT as well)

[Ivan Posva, 2016-02-26 02:05:36]

https://codereview.chromium.org/1737693003/diff/1/runtime/vm/flag_list.h
File runtime/vm/flag_list.h (right):

https://codereview.chromium.org/1737693003/diff/1/runtime/vm/flag_list.h#newc...
runtime/vm/flag_list.h:58: R(enable_type_checks, false, bool, false,            
                         \
On 2016/02/26 01:52:09, Florian Schneider wrote:
> Move up to keep alphabetical sorting.

Done.

https://codereview.chromium.org/1737693003/diff/1/runtime/vm/isolate.h
File runtime/vm/isolate.h (right):

https://codereview.chromium.org/1737693003/diff/1/runtime/vm/isolate.h#newcod...
runtime/vm/isolate.h:646: bool asserts() const { return false; }
On 2016/02/26 01:52:09, Florian Schneider wrote:
> Would return FLAG_enable_asserts work here, and for the other 3 cases? (since
> they should be constant in PRODUCT as well)
> 

Good point. Done.

[Ivan Posva, 2016-02-26 02:07:01]

Description was changed from

==========
- Remove Isolate::Flags structure and store flags directly in isolate.
- Make enable_asserts, enable_type_checks, error_on_bad_override and
  error_on_bad_type release mode flags only.

BUG=
==========

to

==========
- Remove Isolate::Flags structure and store flags directly in isolate.
- Make enable_asserts, enable_type_checks, error_on_bad_override and
  error_on_bad_type release mode flags only.

BUG=
R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8d18298fed7403c48196acddc480350a6de6eeee
==========

[Ivan Posva, 2016-02-26 02:07:02]

Committed patchset #2 (id:20001) manually as
8d18298fed7403c48196acddc480350a6de6eeee (presubmit successful).