Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Side by Side Diff: runtime/vm/intermediate_language_mips.cc

Issue 1737693003: - Remove Isolate::Flags structure and store flags directly in isolate. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address review comments. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS.
6 #if defined(TARGET_ARCH_MIPS) 6 #if defined(TARGET_ARCH_MIPS)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/compiler.h" 10 #include "vm/compiler.h"
(...skipping 404 matching lines...) Expand 10 before | Expand all | Expand 10 after
415 static void EmitAssertBoolean(Register reg, 415 static void EmitAssertBoolean(Register reg,
416 TokenPosition token_pos, 416 TokenPosition token_pos,
417 intptr_t deopt_id, 417 intptr_t deopt_id,
418 LocationSummary* locs, 418 LocationSummary* locs,
419 FlowGraphCompiler* compiler) { 419 FlowGraphCompiler* compiler) {
420 // Check that the type of the value is allowed in conditional context. 420 // Check that the type of the value is allowed in conditional context.
421 // Call the runtime if the object is not bool::true or bool::false. 421 // Call the runtime if the object is not bool::true or bool::false.
422 ASSERT(locs->always_calls()); 422 ASSERT(locs->always_calls());
423 Label done; 423 Label done;
424 424
425 if (Isolate::Current()->flags().type_checks()) { 425 if (Isolate::Current()->type_checks()) {
426 __ BranchEqual(reg, Bool::True(), &done); 426 __ BranchEqual(reg, Bool::True(), &done);
427 __ BranchEqual(reg, Bool::False(), &done); 427 __ BranchEqual(reg, Bool::False(), &done);
428 } else { 428 } else {
429 ASSERT(Isolate::Current()->flags().asserts()); 429 ASSERT(Isolate::Current()->asserts());
430 __ BranchNotEqual(reg, Object::null_instance(), &done); 430 __ BranchNotEqual(reg, Object::null_instance(), &done);
431 } 431 }
432 432
433 __ Push(reg); // Push the source object. 433 __ Push(reg); // Push the source object.
434 compiler->GenerateRuntimeCall(token_pos, 434 compiler->GenerateRuntimeCall(token_pos,
435 deopt_id, 435 deopt_id,
436 kNonBoolTypeErrorRuntimeEntry, 436 kNonBoolTypeErrorRuntimeEntry,
437 1, 437 1,
438 locs); 438 locs);
439 // We should never return here. 439 // We should never return here.
(...skipping 5157 matching lines...) Expand 10 before | Expand all | Expand 10 after
5597 1, 5597 1,
5598 locs()); 5598 locs());
5599 __ lw(result, Address(SP, 1 * kWordSize)); 5599 __ lw(result, Address(SP, 1 * kWordSize));
5600 __ addiu(SP, SP, Immediate(2 * kWordSize)); 5600 __ addiu(SP, SP, Immediate(2 * kWordSize));
5601 } 5601 }
5602 5602
5603 5603
5604 } // namespace dart 5604 } // namespace dart
5605 5605
5606 #endif // defined TARGET_ARCH_MIPS 5606 #endif // defined TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698