Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: runtime/vm/snapshot_test.cc

Issue 1737693003: - Remove Isolate::Flags structure and store flags directly in isolate. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address review comments. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/service_isolate.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/snapshot_test.cc
diff --git a/runtime/vm/snapshot_test.cc b/runtime/vm/snapshot_test.cc
index ad05ebaf3a739a47bd5d8152771703f9fb03538f..26dccc88441f892f0851e6f79842bd6407e99957 100644
--- a/runtime/vm/snapshot_test.cc
+++ b/runtime/vm/snapshot_test.cc
@@ -18,7 +18,6 @@
namespace dart {
-DECLARE_FLAG(bool, enable_type_checks);
DECLARE_FLAG(bool, concurrent_sweep);
// Check if serialized and deserialized objects are equal.
@@ -1579,7 +1578,7 @@ UNIT_TEST_CASE(ScriptSnapshot2) {
// Force creation of snapshot in production mode.
bool saved_enable_type_checks_mode = FLAG_enable_type_checks;
- FLAG_enable_type_checks = false;
+ NOT_IN_PRODUCT(FLAG_enable_type_checks = false);
bool saved_load_deferred_eagerly_mode = FLAG_load_deferred_eagerly;
FLAG_load_deferred_eagerly = true;
bool saved_concurrent_sweep_mode = FLAG_concurrent_sweep;
@@ -1631,7 +1630,7 @@ UNIT_TEST_CASE(ScriptSnapshot2) {
}
// Continue in originally saved mode.
- FLAG_enable_type_checks = saved_enable_type_checks_mode;
+ NOT_IN_PRODUCT(FLAG_enable_type_checks = saved_enable_type_checks_mode);
FLAG_load_deferred_eagerly = saved_load_deferred_eagerly_mode;
{
« no previous file with comments | « runtime/vm/service_isolate.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698