runtime/vm/flow_graph_inliner.cc - Issue 1737693003: - Remove Isolate::Flags structure and store flags directly in isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_inliner.cc

Issue 1737693003: - Remove Isolate::Flags structure and store flags directly in isolate. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address review comments. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_inliner.cc

diff --git a/runtime/vm/flow_graph_inliner.cc b/runtime/vm/flow_graph_inliner.cc

index 7a0808ecb94bcb39226d8ebe780b2f37eefdf19d..95a1c9f1ec9930594f013ac7fb9fb1f2b8dc308e 100644

--- a/runtime/vm/flow_graph_inliner.cc

+++ b/runtime/vm/flow_graph_inliner.cc

@@ -2237,7 +2237,7 @@ static bool InlineSetIndexed(FlowGraph* flow_graph,

call->GetBlock()->try_index());

(*entry)->InheritDeoptTarget(Z, call);

Instruction* cursor = *entry;

- if (flow_graph->isolate()->flags().type_checks()) {

+ if (flow_graph->isolate()->type_checks()) {

// Only type check for the value. A type check for the index is not

// needed here because we insert a deoptimizing smi-check for the case

// the index is not a smi.

« no previous file with comments | « runtime/vm/flow_graph_compiler.cc ('k') | runtime/vm/flow_graph_type_propagator.cc » ('j') | no next file with comments »