Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: runtime/vm/intermediate_language_arm64.cc

Issue 1737693003: - Remove Isolate::Flags structure and store flags directly in isolate. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address review comments. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM64.
6 #if defined(TARGET_ARCH_ARM64) 6 #if defined(TARGET_ARCH_ARM64)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/compiler.h" 10 #include "vm/compiler.h"
(...skipping 343 matching lines...) Expand 10 before | Expand all | Expand 10 after
354 static void EmitAssertBoolean(Register reg, 354 static void EmitAssertBoolean(Register reg,
355 TokenPosition token_pos, 355 TokenPosition token_pos,
356 intptr_t deopt_id, 356 intptr_t deopt_id,
357 LocationSummary* locs, 357 LocationSummary* locs,
358 FlowGraphCompiler* compiler) { 358 FlowGraphCompiler* compiler) {
359 // Check that the type of the value is allowed in conditional context. 359 // Check that the type of the value is allowed in conditional context.
360 // Call the runtime if the object is not bool::true or bool::false. 360 // Call the runtime if the object is not bool::true or bool::false.
361 ASSERT(locs->always_calls()); 361 ASSERT(locs->always_calls());
362 Label done; 362 Label done;
363 363
364 if (Isolate::Current()->flags().type_checks()) { 364 if (Isolate::Current()->type_checks()) {
365 __ CompareObject(reg, Bool::True()); 365 __ CompareObject(reg, Bool::True());
366 __ b(&done, EQ); 366 __ b(&done, EQ);
367 __ CompareObject(reg, Bool::False()); 367 __ CompareObject(reg, Bool::False());
368 __ b(&done, EQ); 368 __ b(&done, EQ);
369 } else { 369 } else {
370 ASSERT(Isolate::Current()->flags().asserts()); 370 ASSERT(Isolate::Current()->asserts());
371 __ CompareObject(reg, Object::null_instance()); 371 __ CompareObject(reg, Object::null_instance());
372 __ b(&done, NE); 372 __ b(&done, NE);
373 } 373 }
374 374
375 __ Push(reg); // Push the source object. 375 __ Push(reg); // Push the source object.
376 compiler->GenerateRuntimeCall(token_pos, 376 compiler->GenerateRuntimeCall(token_pos,
377 deopt_id, 377 deopt_id,
378 kNonBoolTypeErrorRuntimeEntry, 378 kNonBoolTypeErrorRuntimeEntry,
379 1, 379 1,
380 locs); 380 locs);
(...skipping 5200 matching lines...) Expand 10 before | Expand all | Expand 10 after
5581 1, 5581 1,
5582 locs()); 5582 locs());
5583 __ Drop(1); 5583 __ Drop(1);
5584 __ Pop(result); 5584 __ Pop(result);
5585 } 5585 }
5586 5586
5587 5587
5588 } // namespace dart 5588 } // namespace dart
5589 5589
5590 #endif // defined TARGET_ARCH_ARM64 5590 #endif // defined TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698