runtime/vm/service_isolate.cc - Issue 1737693003: - Remove Isolate::Flags structure and store flags directly in isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/service_isolate.cc

Issue 1737693003: - Remove Isolate::Flags structure and store flags directly in isolate. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address review comments. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/service_isolate.cc

diff --git a/runtime/vm/service_isolate.cc b/runtime/vm/service_isolate.cc

index 3d6207ac41fbe64e62376dfe57155392e9e7d0d1..86c8aabf4679ff85009d3d6262b9a8d5dd9fcef4 100644

--- a/runtime/vm/service_isolate.cc

+++ b/runtime/vm/service_isolate.cc

@@ -320,9 +320,8 @@ class RunServiceTask : public ThreadPool::Task {

return;

}

- Isolate::Flags default_flags;

Dart_IsolateFlags api_flags;

- default_flags.CopyTo(&api_flags);

+ Isolate::FlagsInitialize(&api_flags);

isolate =

reinterpret_cast<Isolate*>(create_callback(ServiceIsolate::kName,

« no previous file with comments | « runtime/vm/parser.cc ('k') | runtime/vm/snapshot_test.cc » ('j') | no next file with comments »