Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Side by Side Diff: runtime/vm/intermediate_language_x64.cc

Issue 1737693003: - Remove Isolate::Flags structure and store flags directly in isolate. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address review comments. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/intermediate_language_mips.cc ('k') | runtime/vm/intrinsifier.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64.
6 #if defined(TARGET_ARCH_X64) 6 #if defined(TARGET_ARCH_X64)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/compiler.h" 10 #include "vm/compiler.h"
(...skipping 314 matching lines...) Expand 10 before | Expand all | Expand 10 after
325 static void EmitAssertBoolean(Register reg, 325 static void EmitAssertBoolean(Register reg,
326 TokenPosition token_pos, 326 TokenPosition token_pos,
327 intptr_t deopt_id, 327 intptr_t deopt_id,
328 LocationSummary* locs, 328 LocationSummary* locs,
329 FlowGraphCompiler* compiler) { 329 FlowGraphCompiler* compiler) {
330 // Check that the type of the value is allowed in conditional context. 330 // Check that the type of the value is allowed in conditional context.
331 // Call the runtime if the object is not bool::true or bool::false. 331 // Call the runtime if the object is not bool::true or bool::false.
332 ASSERT(locs->always_calls()); 332 ASSERT(locs->always_calls());
333 Label done; 333 Label done;
334 334
335 if (Isolate::Current()->flags().type_checks()) { 335 if (Isolate::Current()->type_checks()) {
336 __ CompareObject(reg, Bool::True()); 336 __ CompareObject(reg, Bool::True());
337 __ j(EQUAL, &done, Assembler::kNearJump); 337 __ j(EQUAL, &done, Assembler::kNearJump);
338 __ CompareObject(reg, Bool::False()); 338 __ CompareObject(reg, Bool::False());
339 __ j(EQUAL, &done, Assembler::kNearJump); 339 __ j(EQUAL, &done, Assembler::kNearJump);
340 } else { 340 } else {
341 ASSERT(Isolate::Current()->flags().asserts()); 341 ASSERT(Isolate::Current()->asserts());
342 __ CompareObject(reg, Object::null_instance()); 342 __ CompareObject(reg, Object::null_instance());
343 __ j(NOT_EQUAL, &done, Assembler::kNearJump); 343 __ j(NOT_EQUAL, &done, Assembler::kNearJump);
344 } 344 }
345 345
346 __ pushq(reg); // Push the source object. 346 __ pushq(reg); // Push the source object.
347 compiler->GenerateRuntimeCall(token_pos, 347 compiler->GenerateRuntimeCall(token_pos,
348 deopt_id, 348 deopt_id,
349 kNonBoolTypeErrorRuntimeEntry, 349 kNonBoolTypeErrorRuntimeEntry,
350 1, 350 1,
351 locs); 351 locs);
(...skipping 6044 matching lines...) Expand 10 before | Expand all | Expand 10 after
6396 __ Drop(1); 6396 __ Drop(1);
6397 __ popq(result); 6397 __ popq(result);
6398 } 6398 }
6399 6399
6400 6400
6401 } // namespace dart 6401 } // namespace dart
6402 6402
6403 #undef __ 6403 #undef __
6404 6404
6405 #endif // defined TARGET_ARCH_X64 6405 #endif // defined TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language_mips.cc ('k') | runtime/vm/intrinsifier.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698