runtime/tools/create_snapshot_bin.py - Issue 1737693003: - Remove Isolate::Flags structure and store flags directly in isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/tools/create_snapshot_bin.py

Issue 1737693003: - Remove Isolate::Flags structure and store flags directly in isolate. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address review comments. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/tools/create_snapshot_bin.py

diff --git a/runtime/tools/create_snapshot_bin.py b/runtime/tools/create_snapshot_bin.py

index 344c4e342bae1bbd9002d011410ab0791241e962..78213cf304c600ecaa6c83ee1fc134b7a22f90a8 100755

--- a/runtime/tools/create_snapshot_bin.py

+++ b/runtime/tools/create_snapshot_bin.py

@@ -104,7 +104,9 @@ def Main():

return 1

# Setup arguments to the snapshot generator binary.

- script_args = ["--error_on_bad_type", "--error_on_bad_override"]

+ script_args = ["--ignore_unrecognized_flags",

+ "--error_on_bad_type",

+ "--error_on_bad_override"]

# Pass along the package_root if there is one.

if options.package_root:

« no previous file with comments | « runtime/lib/object.cc ('k') | runtime/vm/aot_optimizer.cc » ('j') | no next file with comments »