Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: runtime/vm/intermediate_language_arm.cc

Issue 1737693003: - Remove Isolate::Flags structure and store flags directly in isolate. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address review comments. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/intermediate_language_arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/compiler.h" 10 #include "vm/compiler.h"
(...skipping 355 matching lines...) Expand 10 before | Expand all | Expand 10 after
366 static void EmitAssertBoolean(Register reg, 366 static void EmitAssertBoolean(Register reg,
367 TokenPosition token_pos, 367 TokenPosition token_pos,
368 intptr_t deopt_id, 368 intptr_t deopt_id,
369 LocationSummary* locs, 369 LocationSummary* locs,
370 FlowGraphCompiler* compiler) { 370 FlowGraphCompiler* compiler) {
371 // Check that the type of the value is allowed in conditional context. 371 // Check that the type of the value is allowed in conditional context.
372 // Call the runtime if the object is not bool::true or bool::false. 372 // Call the runtime if the object is not bool::true or bool::false.
373 ASSERT(locs->always_calls()); 373 ASSERT(locs->always_calls());
374 Label done; 374 Label done;
375 375
376 if (Isolate::Current()->flags().type_checks()) { 376 if (Isolate::Current()->type_checks()) {
377 __ CompareObject(reg, Bool::True()); 377 __ CompareObject(reg, Bool::True());
378 __ b(&done, EQ); 378 __ b(&done, EQ);
379 __ CompareObject(reg, Bool::False()); 379 __ CompareObject(reg, Bool::False());
380 __ b(&done, EQ); 380 __ b(&done, EQ);
381 } else { 381 } else {
382 ASSERT(Isolate::Current()->flags().asserts()); 382 ASSERT(Isolate::Current()->asserts());
383 __ CompareObject(reg, Object::null_instance()); 383 __ CompareObject(reg, Object::null_instance());
384 __ b(&done, NE); 384 __ b(&done, NE);
385 } 385 }
386 386
387 __ Push(reg); // Push the source object. 387 __ Push(reg); // Push the source object.
388 compiler->GenerateRuntimeCall(token_pos, 388 compiler->GenerateRuntimeCall(token_pos,
389 deopt_id, 389 deopt_id,
390 kNonBoolTypeErrorRuntimeEntry, 390 kNonBoolTypeErrorRuntimeEntry,
391 1, 391 1,
392 locs); 392 locs);
(...skipping 6430 matching lines...) Expand 10 before | Expand all | Expand 10 after
6823 1, 6823 1,
6824 locs()); 6824 locs());
6825 __ Drop(1); 6825 __ Drop(1);
6826 __ Pop(result); 6826 __ Pop(result);
6827 } 6827 }
6828 6828
6829 6829
6830 } // namespace dart 6830 } // namespace dart
6831 6831
6832 #endif // defined TARGET_ARCH_ARM 6832 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/intermediate_language_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698