runtime/vm/dart_api_impl.cc - Issue 1737693003: - Remove Isolate::Flags structure and store flags directly in isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 1737693003: - Remove Isolate::Flags structure and store flags directly in isolate. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address review comments. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/dart_api_impl.cc

diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc

index 1cff0aa27a6c5a1301a46220766b8b64d0c5f7c3..c3e2a6f17edce4ec76cbd6c46106bf57ca39b0d6 100644

--- a/runtime/vm/dart_api_impl.cc

+++ b/runtime/vm/dart_api_impl.cc

@@ -1240,8 +1240,7 @@ DART_EXPORT Dart_Isolate Dart_CreateIsolate(const char* script_uri,

// Setup default flags in case none were passed.

Dart_IsolateFlags api_flags;

if (flags == NULL) {

- Isolate::Flags vm_flags;

- vm_flags.CopyTo(&api_flags);

+ Isolate::FlagsInitialize(&api_flags);

flags = &api_flags;

}

Isolate* I = Dart::CreateIsolate(isolate_name, *flags);

« no previous file with comments | « runtime/vm/dart.cc ('k') | runtime/vm/flag_list.h » ('j') | no next file with comments »